ngIRCd Release 22~rc1

Update NEWS and ChangeLog for ngIRCd 22 once more ...

Sync "except lists" between servers Up to now, ban, invite, and G-Line lists have been synced between servers while linking -- but obviously nobody noticed that except list have been missing ever since. Until now. Thanks to "j4jackj", who reported this issue in #ngircd.

Allow longer usernames for authentication

Correctly check that a server has a valid hostname and port David Binderman <dcb314@hotmail.com> reported the following compiler warning, which is a real bug in ngIRCd, thanks! conn.c:2077:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

Fix spelling and whitespaces in INSTALL

Update NEWS and ChangeLog for ngIRCd 22

Lists_MakeMask: Don't destroy source buffer

Initialize Conf_ScrubCTCP even when SYSLOG isn't #define'd The "SYSLOG" #define isn't related to "Conf_ScrubCTCP" at all, so initialize the latter even when "SYSLOG" isn't #define'd. Pointed out by wowaname on #ngircd, thanks!

Platforms.txt: Add and update systems - Add armv7l/unk./linux-gnueabihf - Add x86_64/apple/darwin14.0.0 Thanks to Götz Hoffart <goetz@hoffart.de>!

Increase MAX_SERVERS from 16 to 64 There are installations out there that would like to configure more than 16 links per server, so increase this limit. Best would be to get rid of MAX_SERVERS altogether and make if fully dynamic, but start with this quick and dirty hack ...

New "Debian release" 21.1-0ab2 (cherry picked from commit 48fcb97fa4a2762a873d9d693c7a126588a1811d)

Debian: Don't adjust path names that are correct by default

Debian: Correctly set and use "docdir"

Update config.guess and config.sub to recent versions - config.guess: 2014-03-23 - config.sub: 2014-05-01

Add "tests-skipped.lst" to src/testsuite/.gitignore

Test suite/platformtest.sh: Detect when tests have been skipped Detect if some tests have been skipped, for example when telnet(1) or expect(1) is missing: ./contrib/platformtest.sh will echo a warning message now.

Platforms.txt: Add and update systems - Add sparc/unknown/openbsd5.5 - Update powerpc/apple/darwin7.9.0 - Update x86_64/unknown/linux-gnu, Open64 - Update x86_64/unknown/linux-gnu, Sun C 5.12/Solaris Studio 12.3 - Update x86_64/unknown/linux-gnu, tcc 0.9.25 Thanks to Götz Hoffart <goetz@hoffart.de>!

Add "cov-int" directory (Coverity test tool) to .gitignore file

Test suite: Update file headers and comments

Update links to "Arthur" to use the HTTP protocol

ngIRCd Release 21.1 (cherry picked from commit ee28e76df2a73f3bb4bcf69c644eae9a10298a58)

Platforms.txt: Update i686/unknown/gnu0.5

Platforms.txt: Update powerpc/apple/darwin7.9.0 - Update powerpc/apple/darwin7.9.0, gcc 3.3 Thanks to Götz Hoffart <goetz@hoffart.de>!

Platforms.txt: Update x86_64/unkn./linux-gnu, clang 3.x - Update x86_64/unknown/linux-gnu, clang 3.2 => clang 3.3

Platforms.txt: Add and update more systems - update i686/pc/linux-gnu, gcc 2.7.2 - update powerpc/apple/darwin6.8, gcc 3.1 - add powerpc/apple/darwin9.8.0, gcc 4.0.1 Thanks to Götz Hoffart <goetz@hoffart.de>!

doc/Bopm.txt: Update file header

doc/Bopm.txt: Update "connregex" and "kline" for current ngIRCd Thanks to "kerin" on IRC for pointing this out!

Allow "DefaultUserModes" to set all possible modes Let IRC_MODE() detect that the "fake" MODE command originated on the local sever, which enables all modes to be settable using "DefaultUserModes" that can be set by regular MODE commands, including modes only settable by IRC Operators.

Spoofed prefixes: Really kill connection on non-server links This fixes commit 6cbe1308 which only killed the connection when the spoofed prefix itself belonged to a non-server client.

Implement user mode "F": "relaxed flood protection" ngIRCd relaxes its flood protection for users having the user mode "F" set and allows them to rapidly send data to the daemon. This mode is only settable by IRC Operators and can cause problems in the network -- so be careful and only set it on "trusted" clients! User mode "F" is used by Bahamut for this purpose, for example, see <http://docs.dal.net/docs/modes.html#4.9>.

Handle "throttling" in a single function ngIRCd uses "command throttling" and "bps throttling" (bytes per second). The states are detected in different functions, Conn_Handler() and Read_Request(), but handle the actual "throttling" in a common function: this enables us to guarantee consistent behavior and to disable throttling for special connections in only one place, eventually.

Updated config.{guess|sub} to version 2014-03-13

Streamline DEBUG_ARRAY, DEBUG_BUFFER, DEBUG_IO, DEBUG_ZIP Change all #define's to follow the form #define DEBUG_xxx {0|1} to disable (0, default) or enable (1) additional debug messages. And somewhat enhance some DEBUG_BUFFER messages.

conn.c: Code cleanup Reformat and restructure some code, move all SSL related code into one single #ifdef block, for example.

Xcode: remove imp.h and exp.h from project file These files have been removed from ngIRCd in commit 259c314d, "Remove imp.h and exp.h header files".

Re-add #include's for header files of the C file itself This partially reverts commit b130b35f4, "Update #include's: remove unused and add missing ones", but fixes the following compiler and analyzer warnings of Apple Xcode 5: "Semantic issue: No previous prototype for function 'yyy'"

Update copyright notices of recently changed files

Update #include's: remove unused and add missing ones The "deheader" tool (<http://www.catb.org/~esr/deheader/>) has been used to find unused #include directives as well as missing ones. Tested on: - A/UX 3.1.1 - ArchLinux (2014-03-17) - Debian GNU/Hurd - Debian GNU/Linux 6.0.9 - Debian GNU/Linux 7.4 - Fedora 20 - FreeBSD 9.2 - OpenBSD 4.8 - OpenBSD 5.1 - OS X 10.9 - Solaris 11

portab.h: Restructure and clean up code - Don't use HAVE_SYS_TYPES_H, <sys/types.h> is a required header now. - Streamline check for boolean data types. - Better indent #ifdef constructs.

configure[.ng]: <sys/types.h> is a required header file ngIRCd already includes <sys/types.h> in a lot of places without checking for its existence (for example in "ngircd.c", "io.c", ...), therefore make it a required header file.

io.c: <sys/time.h> is only needed when using select() Only include the <sys/time.h> header when using the select() IO API, it isn't required otherwise.

Remove imp.h and exp.h header files These include files don't have a function any more, remove them.

strdup.c: Code cleanup

Don't define SSL_Want{Read|Write}() when SSL is disabled Not even call the "dummy" functions.

Code cleanup, remove blank lines

Fix two K&R C portability issues Fix the following two errors emitted by the Apple K&R C compiler on Apple A/UX: "./class.c", line 47: no automatic aggregate initialization "./class.c", line 47: illegal lhs of assignment operator "./conf.c", line 1052: syntax error Tested on A/UX 3.1.1.

Merge pull request #6 from norrs/pam_server_password_fix Validate server password when PAM is disabled.

Use server password when PAM is compiled in but disabled

CHARCONV: Fix handling conversion errors Don't overwrite already converted text!

Streamline punctuation of log messages See commit d38d153f for details.

Services.txt: Update information for Anope 2.x

IRC_INVITE(): Code cleanup

Streamline punctuation of log messages See commit d38d153f for details.

Correctly use cloaked IRC masks on "INVITE nickname" The cloaked IRC mask of a user is his visible mask, so the daemon has to use it for generating the "one time" entries for the invite list of the given channel. Without this patch, ngIRCd records the real IRC mask which will never match while the target client is "+x", and even worse, will disclose the real mask on "MODE #channel +I" commands :-/ Bug reported by Cahata on #ngircd, thanks!

Use correct sender as target for ISUPPORT replies on "VERSION" This fixes commit 2e168c78 ("Return ISUPPORT(005) numerics on 'VERSION'") and make sure, that the 005 numerics are correctly routed back to the sender.

Return ISUPPORT(005) numerics on "VERSION" This is how ircd-seven, Charybdis, Hybrid, and InspIRCd behave, for example.

configure: Only link "contrib/Debian" if it exists This isn't the case on "VPATH builds", for example.

Merge pull request #5 from grawity/accountname-whois Show account name in WHOIS

Show account name in WHOIS This uses the same numeric as Charybdis and ircu families.

ngircd.conf.5: Update manual page

Merge branch 'no-range-matching' of git://arthur.barton.de/ngircd-alex * 'no-range-matching' of git://arthur.barton.de/ngircd-alex: Remove "range matching" functionality

Use $(MKDIR_P) instead of $(mkinstalldirs) in Makefile's And test for "mkdir -p" using AC_PROG_MKDIR_P in "configure".

Remove "range matching" functionality Don't support "range marching" in our pattern matching code using the "[...]" syntax, because [ and ] are valid characters in nick names and one has to quote them currently using the "\" character, which is quite unexpected. For example: Nick "te[st" => "MODE #channel +b te\[st" And remove quoting altogether, too, because "*" and "?" don't need to be quoted because these characters are not allowed in IRC masks, nicks, and hostnames. Reported by "hifi" (Toni Spets) on IRC, thanks!

Fix configure script and "make check" for TCP Wrappers Add missing #include's and static variables. Problem spotted on OpenBSD.

platformtest.sh: Allow using separate source and build trees Now you can call platformtest.sh using its complete path name from an other directory which is then used for building. See <http://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html> Please not that the build system itself is still (re-)genrated in the original source tree. This can be avoided by passing the "-x" switch to the platformtest.sh script.

Add libwrap at the end of the configure run If libwrap becomes added earlier, other tests may fail because of not all external variables required by libwrap are available when linking: for example allow_severity and deny_severity. This patch adds generic support for the LDFLAGS_END and LIBS_END variables (CFLAGS_END has been implemented already). Problem spotted on OpenBSD.

platformtest.sh: Show only up to 10 bytes of version information

platformtest.sh: New option "-x", don't renegerate build system

Client_SetHostname(): Don't use strlen() to test for value

Test suite: explicitely enable glibc memory checking

Send "fake '*' key" in "MODE -k" replies According to RFC 2812 3.2.3 "Channel mode message" and the examples there, it looks like clients should use "MODE -k <key>" to unset channel keys; and that's how other servers and services behave and do expect it. (But please note that this is NOT the case for "MODE -l"!) In the end, it doesn't make sense to specify a key when UNsetting it at all, and different services behave diffrently when clients do not send the currently set key to unset it - some ignore such calls, for example! But this implementation is quite relaxed, it accepts any key when unsetting channel mode "k" and even accepts no key at all. But the reply will always include an "*" character for every "-k" parameter.

Add "config.cache" to .gitignore file

platformtest.sh: don't use "test -e", it isn't portable

Makefile.am: don't use "test -e", it isn't portable

Support non-standard vsnprintf() return code C99 states that vsnprintf() "returns the number of characters that would have been printed if the n were unlimited"; but according to the Linux manual page "glibc until 2.0.6 would return -1 when the output was truncated" -- so we have to handle both cases ...

Partially revert bc098794: don't require autoconf 2.67 GNU autoconf 2.61 is still sufficient to generate the configure script, even after updating configure.{ng|in}, so don't require a newer version.

doc/Platforms.txt: Update some systems to ngIRCd 21 - update i686/pc/cygwin, gcc 4.8.2 - update x86_64/apple/darwin13.0.0, Apple clang 5.0 - update x86_64/unknown/freebsd8.4, gcc 4.2.1 - update x86_64/unknown/freebsd9.1, gcc 4.2.1 - update x86_64/unknown/linux-gnu, gcc 4.8.2 - update x86_64/unknown/linux-gnu, Open64 - update x86_64/unknown/openbsd4.8, gcc 4.2.1 - update x86_64/unknown/openbsd5.1, gcc 4.2.1

Update configure.ng for autoconf 2.67 We already require GNU autoconf 2.67 for generating our build system (at least this is what the INSTALL document states), so update the build system accordingly and implement all changes that autoupdate(1) suggests: - Update AC_PREREQ and AC_INIT - Use AC_LINK_IFELSE, AC_RUN_IFELSE, and AC_COMPILE_IFELSE - Remove AC_TYPE_SIGNAL (we don't use RETSIGTYPE)

Update Copyright notices for 2014

Merge branch 'bug167-WebircIPAnoDNS' of git://arthur.barton.de/ngircd-alex * 'bug167-WebircIPAnoDNS' of git://arthur.barton.de/ngircd-alex: WEBIRC: Don't respect hostname when DNS is disabled

Merge branch 'bug165-005-NETWORK' of git://arthur.barton.de/ngircd-alex * 'bug165-005-NETWORK' of git://arthur.barton.de/ngircd-alex: Implement new configuration option "Network"

WEBIRC: Don't respect hostname when DNS is disabled When DNS lookups are disabled, don't set the hostname received by the WEBIRC command, but use the IP address instead. Reported by Toni Spets <toni.spets@iki.fi>, thanks! Closes bug #167.

portabtest: Add checks for strdup(), strndup(), and strtok_r()

Implement new configuration option "Network" The new configuration variable "Network" is used to set the (completely optional) "network name", to which this instance of the daemon belongs. When set, this name is used in the ISUPPORT(005) numeric which is sent to all clients connecting to the server after logging in. Closes bug #165.

OS X has a working getaddrinfo() implementation

portabtest: Actually test functions Test functions snprintf(), strlcpy(), strlcat(), vsnprintf() for correctness, not only existance (which was quite useless, because if they weren't available, the program could not have been linked at all ...).

Check for working getaddrinfo() function At least AIX 4.3.3 and 5.1 have a broken implementation of getaddrinfo() which doesn't handle "0" as numeric service correctly. This patch adds a configure check for this case and changes all calling functions to only use getaddrinfo() if it "works". See <http://www.stacken.kth.se/lists/heimdal-discuss/2004-05/msg00059.html>

portabtest: Only use one exit code to indicate errors

Fix spelling

portabtest: Code cleanup

doc/Platforms.txt: Add and update more systems - add i386/unknown/netbsdelf1.5.2, egcs-1.1.2 - update i386/unknown/openbsd5.3, gcc 4.2.1 - add i386/unknown/openbsd5.4, gcc 4.2.1 - add x86_64/unknown/linux-gnu, nwcc 0.8.2 - update x86_64/unknown/linux-gnu, tcc 0.9.25 Thanks to Götz Hoffart <goetz@hoffart.de>!

Fix permanent k/gline Reported by Toni Spets (hifi - at - jnz - dot - fi).

doc/Platforms.txt: Add and update more systems - add i386/unknown/openbsd3.5, gcc 2.95.3 - add x86_64/unknown/linux-gnu, Sun C 5.12 - update mipsel/unknown/linux-gnu, gcc 4.4.5 Thanks to Götz Hoffart <goetz@hoffart.de>!

doc/Platforms.txt: add DragonflyBSD 3.4 on x86_64 Thanks to Götz Hoffart <goetz@hoffart.de>!

doc/Platforms.txt: add OpenBSD 5.4 on HPPA

configure: clean up function definitions

Only use unsetenv() when it is available AIX 4.3 dosn't support it, for example.

conf-ssl.h: make code compatible with pre-ANSI C compilers

vsnprintf.c: make code compatible with ansi2knr tool

Remove unused vsnprintf.c test function

Add comments around some IRC_SetPenalty() calls

Rework the penalty handling slightly Increase the penalty for a command before checking its arguments. This makes the handling more consistent and allow us to move more penalties to Handle_Request().

Move IRC_SetPenalty() to Handle_Request() when possible This centralizes the penalty handling. It also exposes some commands that lack it for our attention.

Introduce a macro to define the command list This will pave the way to other changes and simplifies the entries somewhat.

When sending an error use the IRC_WriteErrClient() variant This ensures that all errors have a 2 second penalty.

On bad /oper set the penalty to 10 seconds This helps against brute-force attempts.

Remove unneded IRC_SetPenalty() calls IRC_WriteErrClient() already calls IRC_SetPenalty(). While here convert some IRC_SetPenalty() + IRC_WriteStrClient() to IRC_WriteErrClient().

Use sizeof() intead of the explicit size

Remove wrong #ifdef in Option_String() This fixes the following error when compiling without zlib support: irc.c: In function ‘Option_String’: irc.c:487: error: ‘options’ undeclared (first use in this function) Reported by "der_baer" on #ngircd.

NEWS/ChangeLog: Clean up version numbers and release dates

ngIRCd Release 21

doc/Platforms.txt: add Mac OS X 10.6.8

Update doc/Platforms.txt

ngircd.init: Make sure no stale PID file is left over

platformtest.sh/Platforms.txt: allow user names up to 8 characters

Check and call arc4random_stir() if present FreeBSD prior to 10.0 does not automatically stir on fork(). Same with current NetBSD. If arc4random_stir() is present assume is needed and call it instead of srand().

Debian: Fix sed(1) rules adjusting "ngircd-full" package Error introduced by last commit :-/

Debian: Fix default "HelpFile" file name in ngircd.conf The "full" package variants must use "/usr/share/doc/ngircd-full/Commands.txt" and "/usr/share/doc/ngircd-full-dbg/Commands.txt" respectively.

ngIRCd Release 21~rc2

platformtest.sh: Detect clang compilers

Add support for longer config lines With the introduction of CipherList we could have longer config lines. Handle up to 1024 bytes and warn if the line will be truncated.

Report the correct file on error

doc/Platforms.txt: Add Open64 and tcc C compilers on Linux Thanks to Götz Hoffart!

platformtest.sh: Detect tcc compiler

Add support for arc4random If arc4random is present it will be used over the srand/rand interface. This fixes some warnings in OpenBSD-current.

Fix another strcat warning missed in commit 4c5b43

platformtest.sh: Clean up GIT source tree, when possible

platformtest.sh: Detect Apple LLVM (clang) compiler

Update (date of) manual pages

ChnageLog file: even more spelling fixes ...

INSTALL file: Update "Upgrade Information"

Fix spelling in NEWS and ChangeLog files

ngircd.c, main(): use strlcat() instead of strcat() This fixes the following warning on OpenBSD 5.3: ngircd.o(.text+0xeb4): In function `main': src/ngircd/ngircd.c:300: warning: strcat() is almost always misused, please use strlcat() Thanks to Götz Hoffart for reporting this!

ngIRCd Release 21~rc1

Update NEWS and ChangeLog files

Actually KILL clients on GLINE/KLINE Kill all clients that match a new GLINE/KLINE mask and genrate apropriate KILL commands. These KILL commands can be superfluous, but are required when the IRC Operator isn't allowd to set remote G-Lines or if there are older servers in the network that don't kill clients on GLINE/KLINE. Closes bug #156.

Don't forward KILL commands for unknown clients

New function IRC_KillClient() to kill clients The old local function Kill_Nick() in irc.c has been an ugly hack. This patch implements a generic function for killing clients. Adjust all callers of Kill_Nick() and respect the return code!

Adjust log messages for invalid and spoofed prefixes Now invalid prefixes aren't logged no more when originating from an other server (besides in debug mode), and spoofed prefixes are correctly logged using LOG_WARNING (from an other server) or LOG_ERR (from a client) levels. In addition, the log message texts have been adjusted to better reflect what will happen: commands with invalid prefixes are ignored and logged, commands with spoofed prefixes will result in the client being disconncted (regular users) or the command being ignored (other servers). This cleans up logging of commands related to already KILL'ed clients.

Remove CLIENT.oper_by_my, Client_SetOperByMe() and Client_OperByMe() All places where Client_OperByMe() is used can either be converted to Client_HasMode(Client, 'o') or Op_Check(). And Op_Check() itself can use the connection handle for deciding whether the IRC Operator is a local user or not.

Add support to show user links using "STATS L" Change "stats L" to show servers and user links and restrict it to IRC Operators.

Log an error (not info) when working directory can't be changed

doc/PAM.txt: add a slightly more useful example

Change the certificate fingerprint digest to sha256 While here correct some indentation.

Change cipher defaults Switch cipher defaults to HIGH:!aNULL:@STRENGTH (OpenSSL) or SECURE128 (GnuTLS).

Merge remote-tracking branch 'alex/bug162-SSLCipherList' * alex/bug162-SSLCipherList: Cipher list selection for GnuTLS ConnSSL_Init_SSL(): correctly set CONN_SSL flag Cipher list selection for OpenSSL ConnSSL_InitLibrary(): Code cleanup

Fix server reconnection In some error cases conn_id will be left as SERVER_WAIT and subsequently ignored in Check_Servers(). Ensure conn_id is set to NONE before returning from New_Server() if we couldn't establish the connection. Prompted by a report from gabrielgi-at-gmail-dot-com.

Cipher list selection for GnuTLS This patch implements the missing functionality for cipher list selection using GnuTLS (our OpenSSL code has this already).

Don't ignore SSL-related errors during startup Without this patch, ngIRCd ignores SSL-related messages and continues to start up but only listens on plain text communication ports -- and this most probably isn't what the administrator wanted ... Closes bug #163.

ConnSSL_Init_SSL(): correctly set CONN_SSL flag The CONN_SSL flag must be set before any calls to ConnSSL_Free()!

Cipher list selection for OpenSSL This patch introduces the possibility to arbitrarily select ciphers which should be promoted resp. declined when establishing a SSL connection with a client by implementing the new configuration option "CipherList". By default, OpenSSL would accept low and medium strength and RC-4 ciphers, which nowadays are known to be broken. This patch only implements the feature for OpenSSL. A GnuTLS counterpart has to be implemented in another patch ... Original patch by Bastian <bastian-ngircd@t6l.de>. Closes bug #162.

TRACE: fix error message when there are too many parameters ircd 2.11 ignores additional parameters silently, but I don't think that this is the correct behaviour either ...

ConnSSL_InitLibrary(): Code cleanup

IRC_SetPenalty(): Code cleanup

Add more penalty times Ensure before every numeric 461 there is a call to IRC_SetPenalty().

Rework check for number of parameters Move most of the checks that return numeric 461 into Handle_Request().

Reorder checks Move oper and Conf_MorePrivacy checks after checking the number of parameters.

Move the IRC_SetPenalty() call after the asserts

Correct numeric returned by whois As per RFC whois should return 431 if no nick is provided. While here convert upper check to use irc-macros. As a bonus we get to set the penalty for free.

Minor cosmetic change Add a define to indicate any client. While I'm here use hex values instead of decimal, it's somewhat clearer that they could be OR'ed together.

Commands.txt: Document proprietary DIE <message> parameter

getpid.sh: use /bin/pidof when available

Don't enforce channel types for other servers The configuration option "AllowedChannelTypes" must only be enforced for regular clients and not for remote servers. Channels created by other servres are always allowed, because they already exist and the daemon must stay in sync with the network.

Only log "IDENT ... no result" when IDENT was looked up Without this patch, ngIRCd logged the "IDENT lookup for connection X: no result"-message even when IDENT lookups have been disabled using the "Ident = no" configuration option, which is a little bit misleading. Reported by "btwe" in #ngircd.

ngircd: use setgid/setuid errno value in error path Need to use saved errno value as strerror argument, else you get bogus output ('success') in the log message.

Show connection flag "s" (SSL) in RPL_TRACE{LINK|SERVER} Now you can check if a server-to-server link is SSL-encrypted or not using the IRC "TRACE" command. Idea by Götz Hoffart, thanks!

Change away to be allocated dynamically

Ignore "operation not permitted" while dropping groups Without this exception, you can't start ngIRCd as user any more, it is analog to setting the user and group ID.

ngircd: discard supplementary group ids on startup The intention was to switch to JUST uid:gid, but setgid is not sufficient. Reported-by: Michael Scherer <misc@zarb.org>

Xcode: update project settings for Xcode 5

Merge branch 'bug159-WebircIPA' * bug159-WebircIPA: Introduce Free_Client() function to free CLIENT structure Save client IP address text for "WebIRC" users

Introduce Free_Client() function to free CLIENT structure

Implement new configuration option "DefaultUserModes" The new configuration option "DefaultUserModes" lists user modes that become automatically set on new local clients right after login. Please note that only modes can be set that the client could set on itself, you can't set "a" (away) or "o" (IRC Op), for example! User modes "i" (invisible) or "x" (cloaked) etc. are "interesting", though. Default: set no modes (like without this patch). Closes bug #160.

Save client IP address text for "WebIRC" users This patch introduces a new field in the CLIENT structure, "ipa_text", which points to an optional textual representation of the client IP address (or NULL) which can be used to store the "real" IP address information of a client using the "WEBIRC" protocol. Without this patch, ngIRCd ignored the <ip-address> paramater ... In addition, the functions Client_SetIPAText() and Client_IPAText() have been introduced to set and get the textual representation of the client IP address. Client_IPAText() can be used even when no "IP address text" has been set before, it then returns the real IP address of the connection. Closes bug #159.

Change strdup() to strndup()

private strndup() implementation in case libc does not provide it

Cosmetic changes to METADATA Update certfp and sort entries.

Silence warning Cast the result of the operation to long, not the time(NULL) call. On systems where sizeof(time_t) is other than long this will produce a warning.

Plug memory leak

Implement account login support This is done via the `accountname' METADATA command and used to automatically identify users after netsplits or across service restarts.

Fix spelling

ngIRCd Release 20.3 (cherry picked from commit bb6e2779636aa6d74bbff474880829f0183a3c94) Conflicts: ChangeLog NEWS

Correctly handle return code of Handle_Write() There have been code paths that ignored the return code of Handle_Write() when sending "notice auth" messages to new clients connecting to the server. But because Handle_Write() would have closed the client connection again if an error occurred, this would have resulted in new errors and assert()'s later on that could have crashed the server (denial of service). Only setups having the configuration option "NoticeAuth" enabled are affected, which is not the default. CVE-2013-5580.

Enhance log messages on "recursive" connection errors

Add some assert() calls to ng_ipaddr library

Update ChangeLog file

Debian init script: test for binary after reading defaults This allows the system administrator to overwrite the DAEMON variable in /etc/defaults/<name> and to use this init script even when the default "/usr/sbin/ngircd" doesn't exist on the system.

Merge branch 'ssl-log-messages' * ssl-log-messages: Make SSL-related log messages more readable ConnSSL_HandleError: Code cleanup, more documentation

Make SSL-related log messages more readable - Don't use internal function names but describe the error. - Streamline wording, use "SSL" for SSL and TLS. - Streamline punctuation.

Use _IRC_ARGC_BETWEEN_OR_RETURN_ when possible

ConnSSL_HandleError: Code cleanup, more documentation

Change log level of "SSL connection shutting down"

Fix 2 bugs introduced in 74514b8c23 Channel_Modes() and Channel_Topic() return static memory that is zeroed at creation time. Fix checking for empty modes and topic so they're propagated correctly.

configure: Don't quote IO backend type(s) It's not needed and inconsistent compared to the other settings. Reported by "allerbest" (Götz Hoffart) on #ngircd, thanks!

IRC_SERVER(): Code cleanup

Introduce new function IRC_WriteErrClient() This function is used to send "error messages", including numerics, back to clients and to automatically enforce a 2 second penalty. With this patch, all error results enforces a delay for the client. All callers of IRC_WriteStrClient(ERR_xxx) have been converted. Please note that this patch prolongs the time "make check" needs to complete its tests, because of lots of new enforced penalties ...

irc-macros.h: Update copyright, don't forget contributors!

irc-write.c: Clean up code and add more documentation comments

Fix return code of some IRC_WriteXXX() functions These functions usually write to more than one target, and therefore can't return value indicating success or failure in a sane way. And, even more omportant, these functions should send to as much as possible clients and not stop at the first client which isn't reachable any more!

Streamline punctuation of log messages See commit d38d153f for details.

Update NEWS and ChangeLog files

More spelling corrections

Inline who_flags_status

Convert more code to use Channel_HasMode

Simplify mode checking on channels and users within a channel Add Channel_HasMode() and Channel_UserHasMode() and use it where possible.

Use Client_HasMode and Client_HasFlag where appropriate

Merge branch 'bug152-AllowedChannelTypes' * bug152-AllowedChannelTypes: Implement new configuration option "AllowedChannelTypes" Introduce "CHANTYPES" #define

Implement new configuration option "AllowedChannelTypes" The new configuration variable "AllowedChannelTypes" lists all allowed channel types (channel prefixes) for newly created channels on the local server. By default, all supported channel types are allowed. If set to the empty string, local clients can't create new channels at all, which equals the old "PredefChannelsOnly = yes" setting. This patch deprecates the "PredefChannelsOnly" variable, too, but it is still supported and translated to the apropriate "AllowedChannelTypes" setting. When "PredefChannelsOnly" is processed, a warning message is logged. Closes bug #152.

More spelling fixes Remove superflous comments, mostly in German. Fix spelling and use american variants for consistency.

Change cloaked hostname to be malloc'd on demand This shaves a few bytes when cloaked hostnames are not used and restricts the cloakhost announcement iif there is something to send.

Introduce "CHANTYPES" #define This #define lists all the prefix characters of all supported channel types, this is "#&+" at the moment.

Add Client_HasFlag() to check if a client has certain flag

Merge remote-tracking branch 'fgsch/certfp' * fgsch/certfp: Simplify MOTD handling Add certificate fingerprint support

Fix spelling

Simplify MOTD handling Merge Show_MOTD_Start, Show_MOTD_Sendline and Show_MOTD_End into IRC_Show_MOTD.

Update irc-server.c to use irc-macros.h And add some comments :-)

Rename XXX_Fingerprint to XXX_CertFp

Add certificate fingerprint support

Commands.txt: Update more descriptions Update description of "CHANINFO", "METADATA", "NJOIN", "SERVER", "SQUIT", "GET", and "POST".

Improved client announcement Move Announce_User() to client.c and rename it to Client_Announce(). Use this in cb_introduceClient() instead of duplicating the code. This fix the certificate fingerprint announcement for new clients. Also ensure the certificate fingerprint is only announced if the client supports it (`M' flag).

Update irc-oper.c to use irc-macros.h

Add penalty times in error paths of generic IRC helper macros Add a 2 second penalty time when the number of parameters is invalid.

Commands.txt: Update more descriptions Update description of "CONNECT", "DIE", "DISCONNECT", "GLINE", "KILL", "KLINE", "OPER", "REHASH", "RESTART" and "WALLOPS".

Add more penalty times in error paths This patch changes the handlers of the "PASS", "NICK", "USER", and "SERVICE" commands to enforce a 2 second penalty when an error like "need more/other parameters" occurs. More functions should follow, I think ...

Commands.txt: Fix <target> description of TRACE command

Update irc-login.c to use irc-macros.h This includes code cleanups, too :-)

Update irc-mode.c to use irc-macros.h This includes code cleanups and more comments, too.

Commands.txt: Update more descriptions Update descriptions of "NICK", "PASS", "PING", "PONG", "QUIT", "USER", "WEBIRC", "SERVICE", and "SVSNICK".

Update irc-channel.c to use irc-macros.h This includes code cleanups, too :-)

Commands.txt: Update description of "PRIVMSG", "NOTICE", and "SQUERY"

Commands.txt: Update more descriptions Update descriptions of "AWAY", "JOIN", "LIST", "MODE", "PART", "TOPC", and "TRACE".

Add "compile" to .gitignore file

Commands.txt: Streamline references to IRC+ protocol

Commands.txt: Update description of the "ERROR" command

Show IRC Operator name when logging a successful OPER command

Update irc.c to use irc-macros.h This includes code cleanups and better documentation for some functions, too.

Merge pull request #4 from fgsch/master Changes for ngircd 21.

Handle services in IRC_WHOIS_SendReply() If the target is a service, advertise it as such and ignore operator mode.

Slightly update ngircd.8 manual page

Fix spelling

Travis-CI: Enable OpenSSL and libiconv support

Updated NEWS and ChangeLog files

Enhance Travis-CI configuration file It now configures the sandbox to build ngIRCd with IPv6, IDENT, PAM, TCP-Wrappers, and zlib support. And it installs expect(1) and telnet(1) for the test suite.

Merge pull request #3 from Cofyc/master irc-info.c: some commands use LINE_LEN as command buffer len

LINE_LEN -> COMMAND_LEN LINE_LEN is configuration file line length

IncludeDir: default to "$SYSCONFDIR/ngircd.conf.d" Now "IncludeDir" defaults to "$SYSCONFDIR/ngircd.conf.d" instead of no directory, but a missing directory is only reported as an error if it has explicitely configured in the main configuration file and simply ignored otherwise. Therefore it is now possible not to touch the default (sample) configuration file at all, and set all distribution and/or system specific configuration options in "*.conf" files stored in "$SYSCONFDIF/ngircd.conf.d/". Thanks to "Elmasloco" for the idea!

"IncludeDir" can't be overwritten by included files

Rename "Mask" variables into "Pattern" in assert() statements This completes commit 3ab00e3a11 which broke debug builds.

Implement new configuration option "IncludeDir" The option "IncludeDir" in the [Options] section can be used to specify a directory which can contain further configuration files and configuration file snippets matching the pattern "*.conf" that should be read in after the main configuration file ("ngircd.conf" by default) has been parsed. Closes bug #157.

Ensure there is enough space for the mask As pointed by Alex while strl{cat,cpy} take the full length we need to leave space to ensure a proper mask is always created so revert the removal of - N from my last change.

conf.c: New function Read_Config_File() This function reads in and parses a single configuration file. Adjust all other functions to display the correct name of the file being read in currently.

Better description for Lists_CheckReason()

Change Lists_MakeMask() to receive a buffer for the mask Change callers accordingly so they don't rely on a global buffer and rename Mask to Pattern where it makes sense since some functions where indeed receiving a pattern and not a mask.

Fix use-after-free on Lists_CheckReason() Change Lists_CheckReason() to receive a buffer where the reason will be stored and its length. Change callers accordingly. Change Class_GetMemberReason() (and its callers) in a similar way so it doesn't rely on a global buffer for the rejected reason.

Update doc/Platforms.txt a little bit ...

Build OS X package with correct file permissions This requires to have the correct permissions in the source tree, which is "root:wheel", which in turn requires root privileges. Therefore the Makefile now tries to become root on "make osxpkg-dest" but tries hard not to require root privileges on "clean" etc.

Xcode: fix detection of host OS, vendor, and CPU

PackageMaker: use relativ path names

Add Travis-CI configuration file

Make configure[.ng] compatible with autoconf 1.10 again The incompatibility has been introduced by commit d0c9f4a6, "configure: search for iconv_open as well as libiconv_open".

Lists_CheckReason(): Check for Client_MaskCloaked() Look for possible cloaked Masks in Lists. Users with +x usermode can be banned with their cloaked hostname now.

Services.txt: Anope 1.9.8 has been released now

Commands.txt: Update description of the "KILL" command

Conn_Handler(): Don't test for penalty times The Conn_Handler() main loop calls Handle_Buffer() which checks for the "penalty time" of each client itself, so don't do it twice.

Don't read SSL client data before DNS resolver is finished Fix the cb_clientserver_ssl() callback function to not read in and store SSL encrypted client data before the asynchronous DNS resolver sub-process has finished: This could have resulted in discarding the resolved client hostname and IDENT reply afterwards, because in some situations (timing dependent) the NICK and USER commands could have already been read in from the client, stored in the buffer, and been processed. Thanks to Julian Brost for reporting the issue and testing, and to Federico G. Schwindt <fgsch@lodoss.net> for helping to debug it!

Increase password length limit to 64 characters Closes bug #154.

doc/Services.txt: Update Anope status and URL

Commands.txt: Update description of the "KICK" command

Commands.txt: Update description of the "INVITE" command

irc-op.c: use irc-macros.h

irc-cap.c: use irc-macros.h

irc-op.c: Update source code documentation

irc-cap.c: Update source code documentation

Add new _IRC_ARGC_EQ_OR_RETURN_ macro to irc-macros.h

Add new _IRC_ARGC_BETWEEN_OR_RETURN_ macro to irc-macros.h

irc-cap.c: move static functions to the top of the file And remove now unnecessary (local) prototypes.

Update Doxygen configuration

Clean up Xcode project file, remove outdated files, add missing

src/testsuite/README: add whois-test.e

irc-login.c: conenction -> connection Introduced by commit d3ef2239 as of Sun Jan 16 2011 ... Thanks to Patrik Schindler <poc@pocnet.net> for reporting this!

Merge branch 'bug151-iconv' into master * bug151-iconv: configure: search for iconv_open as well as libiconv_open

Merge branch 'bug153-ServerMask' into master * bug153-ServerMask: Update irc-info.c to use irc-macros.h Add new irc-macros.h to project irc-info.c: add/streamline function documentation comments irc-info: move static functions at the top of the file Implement new function Client_SearchServer() Conflicts: src/ngircd/irc-info.c

configure: search for iconv_open as well as libiconv_open On some installations iconv_open() is actually libiconv_open(). iconv_open() is the glibc version while libiconv_open() is the libiconv version. This patch enables ngIRCd to detect both cases. Tested on OpenBSD 5.1. Closes bug #151.

configure: conversation -> conversion

Update irc-info.c to use irc-macros.h This includes: - move IRC_SetPenalty() at the beginning of the handler functions, - use macros provided by irc-macros.h, - code cleanup. The main benefits of this patch are core size reduction, streamlined structure of the handler functions, and enhanced functionality: because of the _IRC_GET_TARGET_SERVER_OR_RETURN_() macro using the Client_SearchServer() function, the target of the specific IRC command can now be given server names, server mask, or the nickname of a user connected to the server. Closes bug #153.

ngIRCd Release 20.2 (cherry picked from commit c45d9dd1f08fddb95fa01d62c69848cd753a3161)

Add new irc-macros.h to project This file prvides some macros for common tasks required by functions implementing handlers for IRC commands: * _IRC_ARGC_LE_OR_RETURN_ * _IRC_ARGC_GE_OR_RETURN_ * _IRC_GET_SENDER_OR_RETURN_ * _IRC_GET_TARGET_SERVER_OR_RETURN_

KICK: Fix denial of service bug Test if the user that it is to be kicked is on the channel before user channel modes are tested. Otherwise assert( cl2chan != NULL ); in line 742 would fail and stop the service.

irc-info.c: add/streamline function documentation comments Add missing comments, streamline wording, and remove references to the RFCs: this will be added to ./doc/Commands.txt with an other patch and we want to avoid redundancy ...

sighandlers.c: Update some log messages

irc-info: move static functions at the top of the file

my_sd_listen_fds(): really return an "int" This fixes the following warning using Apple LLVM version 4.2 (clang-425.0.24) on OS X: src/ngircd/conn.c:157:9: Implicit conversion loses integer precision: 'long' to 'int'

Implement new function Client_SearchServer() This function returns the server structure of a client or a given "mask"; it is useful for implemention handlers for commands like "COMMAND *.net", which should work on a server matching "*.net". Please note that the local server is always returned when it matches the mask, but besides that, the order is completely arbitrary.

Merge branch 'bug155-allowAtInUser' * bug155-allowAtInUser: Allow "@" character in user names for authentication

Exit message: use singular & plural :-)

Allow "@" character in user names for authentication The "@" character isn't allowed in IRC usernames, because it is the separator between user name and hostname in IRC masks: <nickname>!<username>@<hostname> This patch accepts user names including "@" characters, saves the unmodified name for authentication but stores only the part in front of the "@" character as "IRC user name". And the latter is how ircd2.11, Bahamut, and irc-seven behave as well. Closes bug #155.

Merge branch 'systemd' * systemd: ngircd.sock: explicitely bind to IPv4 and IPv6 addresses Show address and port of sockets passed-in by systemd(8) Check type of sockets passed-in by systemd(8) Adjust severity levels of some log messages New configuration option "IdleTimeout": exit daemon when idle Implement support for systemd(8) "socket activation" contrib/README: add more files

autogen.sh: Check for autoconf/automake wrapper scripts For example OpenBSD uses a "autoconf" and "automake" wrapper script which tells the user to set AUTOCONF_VERSION and AUTOMAKE_VERSION environment variables. This patch enhances autogen.sh to not detect these wrapper scripts as regular autoconf/automake commands but to set the required environment variables after detecting the real "command-X.Y" commands. Tested on OpenBSD 5.1.

ngircd.sock: explicitely bind to IPv4 and IPv6 addresses

Commands.txt: spelling fixes ...

"WHO <hostmask>": use displayed hostname for matching Use the currently "displayed hostname" (which can be cloaked!) for hostname matching, not the real one. In other words: don't display all the cloaked users on a specific real hostname! Thanks to DNS <dns@rbose.org> for reporting this issue.

autogen.sh: Don't use "egrep -o", use "sed" "egrep -o" isn't portable and not available on OpenBSD, for example. So let's use sed instead to get the automake version. The expression used now is less specific but should work as well ...

Show address and port of sockets passed-in by systemd(8)

Merge branch 'HelpText' * HelpText: (22 commits) Commands.txt: Update description of the "USERS" command Commands.txt: Update description of the "SUMMON" command Commands.txt: Update description of the "SERVLIST" command Commands.txt: Update description of the "WHOWAS" command Commands.txt: Update description of the "WHOIS" command Commands.txt: Update description of the "WHO" command Commands.txt: Update description of the "VERSION" command Commands.txt: Update description of the "USERHOST" command Commands.txt: Update description of the "TIME" command Commands.txt: Update description of the "STATS" command Commands.txt: Update description of the "NAMES" command Commands.txt: Update description of the "MOTD" command Commands.txt: Update description of the "LUSERS" command Commands.txt: Update description of the "LINKS" command Commands.txt: Update description of the "ISON" command Commands.txt: Update description of the "INFO" command Commands.txt: Update description of the "ADMIN" command Commands.txt: Add description for the "CHARCONV" command Commands.txt: Add description for the "CAP" command Commands.txt: Import descriptions from "rbose/command_help" ...

Rename ports_initlisteners() to Init_Listeners()

IRC_WHO_Channel(): Use strlcpy() instead of strcpy() This fixes the following warning, at least on OpenBSD 4.8: irc-info.o(.text+0x2427): In function `IRC_WHO': src/ngircd/irc-info.c:896: warning: strcpy() is almost always misused, please use strlcpy()

Check type of sockets passed-in by systemd(8) This patch makes sure that ngIRCd doesn't try to handle sockets of unsupported types, for example of AF_INET6 sockets when ngIRCd isn't compiled with support for IPv6 ...

Commands.txt: Update description of the "USERS" command

NewListener(): Code cleanup

Streamline punctuation of log messages Make sure that all log messages end with a correct punctuation mark. The rules for formatting log messages are: 1. Add punctuation marks to all messages passed to the actual logging functions like Log() and LogDebug(). 2. Don't add any punctuation marks to messages that are stored in variables for later use or are passed over the network. 3. IP addresses, DNS host names and IRC server names should be quoted. 4. Messages originating in the network should be quoted (at least if they are "untrusted" or variable). Most probably this patch doesn't fix all mistakes, but it should be a good starting point ...

Adjust severity levels of some log messages

Commands.txt: Update description of the "SUMMON" command

Enable WHOIS to display information about IRC Services This patch introduces the new numeric 310(RPL_WHOISSERVICE) and enables WHOIS to display information about IRC services. This numeric is used for this purpose by InspIRCd, for example -- but as usual, other numerics are in use, too, like 613 in UltimateIRCd ... Please note that neither the Operator (+o) not the "bot status" (+B) of an IRC service id displayed in the output. Change suggested by Federico G. Schwindt <fgsch@lodoss.net>, Thanks.

configure: "netinet/in_systm.h" is optional The header file "netinet/in_systm.h" already is optional in ngIRCd, so don't require it in the configure script. Now ngIRCd can be built on Minix 3 again :-)

Commands.txt: Update description of the "SERVLIST" command

New configuration option "IdleTimeout": exit daemon when idle This patch implements a new configuration option "IdleTimeout" in the [Limits] section of the configuration file which can be used to set a timeout (in seconds) after which the whole daemon will shutdown when no more connections are left active after handling at least one client. The default is 0, "never". This can be useful for testing or when ngIRCd is started using "socket activation" with systemd(8), for example.

contrib/Debian/rules: Do no compress Commands.txt This is required, because ngIRCd can't use a compressed file as help text ... (cherry picked from commit 6d09b4f366f656f6d2732ea96a653e086380e458)

Commands.txt: Update description of the "WHOWAS" command

Implement support for systemd(8) "socket activation" This patch enables ngIRCd to work with listening sockets already initialized and passed-in by systemd(8) and hereby to support on-demand "socket activation". systemd(8) uses two environment variables to pass information about the sockets to ngIRCd, LISTEN_PID and LISTEN_FDS, and this mechanism only kicks in when both variables are set. In all other cases, and therefore in most installations out there, nothing changes at all. Please note: If socket activation is in effect, ngIRCd will not initialize any (other) soeckets on its own! All sockets must be configured in the systemd(8) socket unit configuration file in this case, see ./contrib/ngircd.socket for example. Probably it would be interesting to match passed-in sockets to configured listening sockets and to initialize all the remaining ones not already set up by systemd(8), but this is kept back for an other patch ... See - <http://0pointer.de/blog/projects/socket-activation.html> - <http://0pointer.de/blog/projects/socket-activation2.html> - <http://www.freedesktop.org/software/systemd/man/systemd.socket.html>

AUTHORS: Update list of contributors

Commands.txt: Update description of the "WHOIS" command

contrib/README: add more files

AUTHORS: Use "email address syntax"

Commands.txt: Update description of the "WHO" command

ngircd.service: Use "forking" service type Don't run ngIRCd in forground mode but let it daemonize itself. This enhances the log output of "systemctl status ngircd.service", because now ngIRCd doesn't print out its PID and timestamp on each log message which is redundant: it becomes logged by systemd/journald already.

Commands.txt: Update description of the "VERSION" command

Return better "Connection not registered as server link" errors Now ngIRCd returns a more specific error message for numeric ERR_NOTREGISTERED(451) when a regular user tries to use a command that isn't allowed for users but for servers: ERR_NOTREGISTEREDSERVER(451).

Commands.txt: Update description of the "USERHOST" command

MODE: don't report error on "more modes than parameters" Don't report ERR_NEEDMOREPARAMS(461) when a MDOE command with more modes than nicknames is handled, as well as for channel limit and key changes without specifying the limit or key parameters. This is how a lot (all?) other IRC servers behave, including ircd2.11, InspIRCd, and ircd-seven. And because of clients (tested with Textual and mIRC) sending bogus MODE commands like "MODE -ooo nick", end-users got the expected result as well as correct but misleading error messages ... If ngIRCd is compiled using "strict mode", these errors are still reported. Reported-by: Tim <tim@stackwatch.net>

Commands.txt: Update description of the "TIME" command

Correctly detect when SSL subsystem must be initialized This patch introduces the new function Conf_SSLInUse() to check when the current server configuration requires the SSL subsystem to be initialized and accounts incoming as well as outgoing connections -- so this fixes commit bb20aeb9 ("Initialize SSL when needed only, and disable SSL on errors") which only handled the inbound case ... Tested-by: Brett Smith <brett@w3.org>

Commands.txt: Update description of the "STATS" command

configure: use AS_HELP_STRING for --with-iconv

Commands.txt: Update description of the "NAMES" command

autogen.sh: Enforce serial test harness on automake >=1.13

Commands.txt: Update description of the "MOTD" command

autogen.sh: Reformat messages.

Commands.txt: Update description of the "LUSERS" command

Merge branch 'bug145-ProvideHelp' * bug145-ProvideHelp: Use "${docdir}/Commands.txt" as help text file Add a note that "help file" is updated on startup and REHASH only Add doc/Commands.txt which should document all commands Implement Help() function parsing and returning the help text Document "HelpFile" in sample-ngircd.conf and ngircd.conf.5 Implement new configuration option "HelpFile" IRC_HELP(): Code cleanup Refactor Read_Motd() into Read_TextFile()

Commands.txt: Update description of the "LINKS" command

ngIRCd Release 20.1

Use "${docdir}/Commands.txt" as help text file

Commands.txt: Update description of the "ISON" command

Update Copyright notices for 2013

Add a note that "help file" is updated on startup and REHASH only

Commands.txt: Update description of the "INFO" command

Add doc/Commands.txt which should document all commands This document can be used as "help text", too, see configuration option "HelpFile" in ngircd.conf(5). Please note that this file in its current state is far from complete, only a few commands are documented, but you should get an idea how it works. So please send in patches adding the remaining parts! :-)

Allow ERROR command on server and service links only Ignore it and add a penalty time on all other link types.

Commands.txt: Update description of the "ADMIN" command

Implement Help() function parsing and returning the help text This function parses the already read in help text and sends the requested portions to the user. Parsing is done as following when a user user issues a "HELP <cmd>" command: 1. Search the file for a line "- <cmd>", 2. Output all subsequent lines that start with a TAB (ASCII 9) character to the client using NOTICE commands, treat lines containing a single "." after the TAB as empty lines. 3. Break at the first line not starting with a TAB character. This format allows to have information to each command stored in this file which will not be sent to an IRC user requesting help which enables us to have additional annotations stored here which further describe the origin, implementation details, or limits of the specific command. A special "Intro" block is returned to the user when the HELP command is used without a command name.

Get rid of Conn_ResetPenalty(), it is unused

Commands.txt: Add description for the "CHARCONV" command

Document "HelpFile" in sample-ngircd.conf and ngircd.conf.5

Mode setting: only check channel user modes when on channel Only check the channel user modes of the initiator if he is joined to this channel and not an IRC operator enforcing modes (which requires the configuration option "OperCanUseMode" to be enabled), because trying to check channel user modes of a non-member results in this assertion: Assertion failed: (cl2chan != NULL), function Channel_UserModes, file channel.c, line 742. This closes bug #147, thanks to James Kirwill <james.kirwill@bk.ru> for tracking this down!

Commands.txt: Add description for the "CAP" command

Implement new configuration option "HelpFile" This new configuration option allows to specify a specially formatted text file which can be used by the HELP command to provide information about the commands and their syntaxes.

Add some more casts in assert() statemens This fixes the following warning messages of gcc 4.5.3 on Cygwin when building with debug code enabled: ng_ipaddr.c: In function ‘ng_ipaddr_init’: ng_ipaddr.c:52:2: warning: comparison between signed and unsigned integer expressions ng_ipaddr.c:53:20: warning: comparison between signed and unsigned integer expressions resolve.c: In function ‘ForwardLookup’: resolve.c:271:3: warning: comparison between signed and unsigned integer expressions

Commands.txt: Import descriptions from "rbose/command_help" Import command description texts from the "rbose/command_help" branch, which have been written by DNS <dns@rbose.org> -- thanks a lot!

IRC_HELP(): Code cleanup

Makefiles: Correctly quote sed expressions Now the Makefiles support spaces in "$sysconfdir", which isn't uncommon for Cygwin for example, when $HOME contains whitespaces ("/home/User Name") and ngIRCd is installed into the user home ("./configure --prefix=$HOME").

Commands.txt: Reorder some commands Reorder some commands and introduce new section "Connection Handling". Idea by DNS <dns@rbose.org>, thanks!

Refactor Read_Motd() into Read_TextFile() Now this function allows to read arbitrary text files into arrays.

Add Cygwin binaries (*.exe) to .gitignore files

Commands.txt: Fix some wording and spelling

Add a cast in ForwardLookup() to fix a gcc warning on Cygwin This fixes the following warning message of 4.5.3 on Cygwin: resolve.c: In function ‘ForwardLookup’: resolve.c:273:21: warning: comparison between signed and unsigned integer expressions

ngIRCd Release 20

Update NEWS and ChangeLog files

Allow user names up to 20 characters This patch allows user names up to 20 characters when ngIRCd has not been configured for "strict RFC mode". Patch suggested by Brett Smith <brett@w3.org>, see <http://arthur.barton.de/pipermail/ngircd-ml/2012-October/000579.html>.

ngIRCd 20~rc2

Update NEWS and ChangeLog files

Update doc/Platforms.txt

Rework cloaked hostname handling, implement "METADATA cloakhost" Now ngIRCd uses two fields internally, one to store the "real" hostname and one to save the "cloaked" hostname. And both fields can be set independently using the "METADATA host" and "METADATA cloakhost" commands. This allows "foreign servers" (aka "IRC services") to alter the real and cloaked hostnames of clients without problems, even when the user itself issues additional "MODE +x" and "MODE -x" commands.

RPL_UMODEIS: send correct target name, even on server links

Client_HostnameCloaked() -> Client_HostnameDisplayed()

platformtest.sh: Only generate configure script when missing

Update platformtest.sh to follow autoconf changes

Test suite: correctly execute tests when stdout is redirected

Add a few casts, fix compiler warnings on NetBSD 5 This fixes a few warnings of this type: XXX.c: In function 'AAA': XXX.c:YY: warning: array subscription has type 'char' Tested on NetBSD 5.0.2 with gcc 4.1.3.

irc-info.c: Use strlcpy() instead of strcpy() This fixes the following warning of gcc (tested on OpenBSD 5.0:) irc-info.c:990: warning: strcpy() is almost always misused, please use strlcpy

ngIRCd 20~rc1

Update Xcode project files

conf.c: Use strlcpy() instead of strcpy() This fixes the following warning of gcc on OpenBSD 5.0: conf.c:728: warning: strcpy() is almost always misused, please use strlcpy()

tool.h: Don't check for and #define PF_INET This is correctly handled by ipaddr/ng_ipaddr.h today, and the check in tool.h isn't required any more -- and caused errors on OpenBSD 5.0: In file included from ./../tool/tool.h:23: /usr/include/arpa/inet.h:74: warning: "struct in_addr" declared inside parameter list

conf-ssl.h: Use "gnutls_session_t" instead of "gnutls_session" This fixes the following warning with current versions of GnuTLS: conf-ssl.h:36: warning: "gnutls_session" is deprecated

Add new IRC+ server flag "X": "XOP modes supported" This flag indicates, that the server supports the enhanced "xop channel user modes", like channel owner, admin, and halfop. This information is used to make sure that no unsupported CHANINFO commands are sent to servers not supporting such mode prefixes, for example.

Update autoconf/automake version numbers in doc/HowToRelease.txt

Update NEWS and ChangeLog files

Remove Anope "ngircd" protocol module patches Starting with Anope 1.9.8, the ngIRCd protocol module is included in the Anope distribution, so there's no longer any need to support our own (but now heavily outdated!) patches. Therefore remove them.

doc/Services.txt: Update documentation for Anope 1.9.8 Starting with Anope 1.9.8, the ngIRCd protocol module is rewritten from scratch by "DukePyrolator" and included in the Anope distribution. So no patching is required any more, yeah! Drawback: Anope 1.9.8 is in development and not yet released ...

Correctly add irc-metadata.{c|h} to Makefile.ng ...

doc/Protocol.txt: Document METADATA command

Generate "METADATA host" commands on "MODE +/-x" Use "METADATA host" commands to let servers supporting this command know which (possibly cloaked) hostname is in effect for a specific client. This prevents "double cloaking" of hostnames and even cloaked hostnames are in sync on all servers supporting "METADATA" now.

Don't cloak already cloaked hostname when using METADATA A client for which a METADATA command has been received from one of its peers got the client flag "M" set. So it's safe to assume that such a client gets "METADATA host" commands for its cloaked hostname and the server must not cloak the hostname on its own, even when the client mode "+x" is set.

Implement METADATA command to update client metadata The METADATA command can be used by other servers to update "metadata" of registered clients, like the client info text ("real name"), user name, and hostname: :<prefix> METADATA <target> <key> :<value> It is distributed in the network, unknown <key> names are silently ignored and passed on, too. This allows for further extensions.

doc/Protocol.txt: add/fix CHARCONV description

PredefChannelsOnly: Fix message for non pre-defined channels If PredefChannelsOnly is enabled, and if someone tries to create a channel which does not exist, then the error message is a 474. The 474 Error message changed recently and does not match anymore: 'Cannot join channel (+b) -- You are banned'. Changed the error message to numeric 403 'No such channel'. Bug introduced by commit 9a82304a. (cherry picked from commit 2c2e08f34187a33c1da745995c5f213e33a91410)

Test suite: add some "remote checks" to whois-test.e

Send NICK commands with prefix of (target) user Now NICK commands are always generated using the prefix of the target user, even when the nickname change has been initiated by some other (pseudo) server or using the SVSNICK command. In this case, the prefix of the initiator has been used, but this isn't compatible with clients (at least weechat and irssi don't handle such NICK commands correctly).

Update doc/Services.txt, sort services alphabetically

Implement SVSNICK command to change remote nicknames The SVSNICK command allows other servers (and services on "pseudo-servers") to forcefully change nicknames of remote users. Syntax: ":<from> SVSNICK <oldnick> <newnick>" The SVSNICK command itself doesn't change the nickname, but it becomes forwarded to the server to which the user is connected to. And then this server initiates the real nickname changing using regular NICK commands. This allows to still run networks with old servers not supporting the SVSNICK command, because SVSNICK commands for nicknames on such servers are silently ignored and don't cause a desync of the network.

IRC_NICK(): Code cleanup, new function Change_Nick()

Spelling fix: "nick name" -> "nickname"

Xcode: correctly #define PACKAGE and PACKAGE_NAME

Fix warning message introduced when cleaning up IRC_SERVER() This reverts a not intentional code change and fixes the following compiler warning message (tested with gcc 4.4.5): irc-server.c: In function "IRC_SERVER": irc-server.c:142: warning: suggest parentheses around operand of "!" or change "&" to "&&" or "!" to "~"

Make server reconnect time a little bit more random Add randomly up to 15 seconds to the reconnect delay for outgoing server links when the connection has been "short" and therefore the "ConnectRetry" delay is being enforced. This should make it even more unlikely that two servers deadlock each other when both are trying to connect to the other one at the same time, for example in test environments.

Don't accept connections for servers already beeing linked If two servers try to link each other, there was a time frame that could result in one connection overwriting the other, e. g. the incoming connection overwriting the status of the outgoing one. And this could lead to all kind of weirdness (even crashes!) later on. So now such incoming connections are dropped. But this most probably prevents the two servers from linking until timing changes somehow (network latency?) because each server drops the incoming connection of the other one, so no connection survives in the end. But this has to be addressed by an other patch ...

IRC_SERVER(): Code cleanup

Use lowercase "package name" for syslog logging again This is how ngIRCd up to release 19.2 behaved; "bug" introduced by commit 67e882, "configure.in: require autoconf 2.67 and automake 1.11", which changed the "PACKAGE_NAME" to "ngIRCd"; so use "PACKAGE" which still is the lowercase version for initializing syslog logging.

Document new configuration option "MaxListSize"

Make the maximum /list reply length a configurable limit.

Update NEWS and ChangeLog files

Allow remote servers and IRC Ops to change channel topics Remote servers are always allowed to change all channel topics, and IRC Operators are allowed to change all channel topics if the configuration option "OperCanUseMode" is enabled. Bug introduced by commit 7b01bb8 and reported by DNS777.

Increased maximum number of possible user and channel modes Currntly ngIRCd supports 13 user and 15 channel modes, because there have been quite a few additions since our last release. But our data structures can only hold 15 user and -- even worse! -- only 9 channel modes! So enlarge the buffers to 20 bytes (actually 21 including NULL) to allow storing of all mode characters and to have some space left for more modes to come ... (cherry picked from commit 8996d777621d88d4bcc439ab4792b2814920687f)

Update error messages for user mode +b and channel Mode +M. Replaced error message for channel mode +M with ERR_NEEDREGGEDNICK_MSG (used by Bahamut, inspircd, ircu & Unreal too) and using numeric 477 and the msg simliar like inspircd. Replaced the error message ERR_CANNOTSENDTONICK_MSG for user mode +b with ERR_NONONREG_MSG and using numeric 486, similar like unrealircd. (cherry picked from commit 55a61ab17f63a9e757b7c7598c31b98ce5a132e8 and commit 3737d9ab7da1ea0485cefc07c65dc5308bf0db02)

Test suite: add more checks to whois-test.e

Add "i586/pc/haiku" to doc/Platforms.txt

Disable UID/GID checks on "single user OS" Don't abort on "single user operating systems" that don't know more than one user account and therefore can't change user and group IDs. Currently, the only such system supported by ngIRCd is Haiku, a BeOS clone.

Search gethostbyname() in libbind and libnetwork This is required for Haiku (BeOS clone) at least.

Update manual pages Among other little things, bring project description in line with website.

Test suite: add test for user mode "b"

Implement user mode "b": block messages When a user has set mode "b", all private messages and notices to this user are blocked if they don't originate from a registered user, an IRC Op, server or service. The originator gets an error numeric sent back in this case, ERR_CANNOTSENDTONICK_MSG(976), which is/was(?) used by KineIRCd, too. This closes bug #144.

Fix ERR_CANNOTSENDTOCHAN_MSG message This error message is not only used if one can not send to a channel because it is moderated, but for _all_ reasons when a message can not be delivered (moderated, banned, no external messages, ...), so strip the "(+m) -- Moderated" part of the error message again. Bug introduced by commit 9a82304a.

Shorten filenames of Anope protocol module patchfiles Filenames have been too long and couldn't be stored in all tar archive formats ...

WHOIS: show RPL_WHOISHOST_MSG to all IRC Ops in the network Not only show RPL_WHOISHOST_MSG to local IRC opreators, but show it to all IRC operators in the network. And don't show it to anybody if the "more privacy" configuration option is enabled. This closes bug #134.

Test suite: make expect scripts more verbose Now tests.sh transforms each expect script it executes using sed(1) and inserts a 'puts -nonewline stderr "."' in front of each "expect" command.

Test suite: remove indentation of messages

Merge branch 'bug141-ModesQq' This closes bug #141. * bug141-ModesQq: KICK-protect IRC services Implement channel mode "Q" and user mode "q" Conflicts: src/ngircd/defines.h src/ngircd/messages.h

Show active user modes in WHOIS reply Implement numeric RPL_WHOISMODES_MSG(379) and show user modes in the reply of the WHOIS command for the user himself or, if MorePrivacy isn't set, for request initiated by an IRC operator. Numeric 379 is used by Unreal and InspIRCd for this purpose, too. Closes bug #129.

KICK-protect IRC services

Implement channel mode 'V' (invite disallow) If the new channel mode "V" is set, the INVITE command becomes invalid and all clients get the new ERR_NOINVITE_MSG(518) reply. Unreal and InspIRCd uses this mode, too. This closes bug #143.

Implement channel mode "Q" and user mode "q" Both modes protect users from channel kicks: only IRC operators and servers can kick users having mode "q" or in channels with mode "Q". Original patch by DNS777 <dns@rbose.org>, thanks! This closes bug #141.

Allow channel admins to "de-admin" channel members This patch fixes unsetting of channel user mode "+a" (channel admin) and adds a better error message: without this patch, a channel admin is unable to unset this mode. This closes bug #142.

Define HAVE_SETSID for Mac OS X Xcode builds

Merge branch 'bug109-CHARCONV' This closes bug #109. * bug109-CHARCONV: Debian: require "telnet" or "telnet-ssl" for building Debian ngircd-full[-dbg]: enable CHARCONV Add "CHARCONV" to "feature string" when enabled Implement new IRC+ "CHARCONV" command Added new configure option "--with-iconv" Conflicts: src/ngircd/messages.h

Fix spelling: ERR_CHANOPPRIVTOLOW_MSG -> ERR_CHANOPPRIVTOOLOW_MSG Thanks to DNS for pointing this out, see bug #126!

Debian: require "telnet" or "telnet-ssl" for building

Makefile.am: don't use "make -C", it isn't portable

Debian ngircd-full[-dbg]: enable CHARCONV

Test suite: don't use "mkdir -p" "mkdir -p" is not supported on all platforms. Tested with Apple A/UX 3.1.x.

ERR_CHANNELISFULL_MSG: better wording (cherry picked from commit 0fcfa7e00fa8e098dd3724c7188c88ac82a52881)

Add "CHARCONV" to "feature string" when enabled

Fix getpid.sh to work on Apple A/UX again