commit 8ec17063a6e651229e04605592ce3d6114075655 from: Alexander Barton date: Tue Apr 17 10:54:38 2012 UTC Lists_Add(): use size of destination when copying data This fixes the following warning of clang: /src/ngircd/lists.c:152:44: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] But it isn't a real problem, because the size of the source always is the same than the size of the destination ... commit - 67bd1bf34fc3f7bebb304cdf84284523c8ea09f5 commit + 8ec17063a6e651229e04605592ce3d6114075655 blob - 4f57ca73521f6b65f568d0aefa9c60b844a685c6 blob + 45a4874b6e94f268aa2a0942cdf249c4aec12a24 --- src/ngircd/lists.c +++ src/ngircd/lists.c @@ -149,7 +149,8 @@ Lists_Add(struct list_head *h, const char *Mask, time_ if (Reason) { newelem->reason = malloc(strlen(Reason) + 1); if (newelem->reason) - strlcpy(newelem->reason, Reason, strlen(Reason) + 1); + strlcpy(newelem->reason, Reason, + sizeof(newelem->reason)); else Log(LOG_EMERG, "Can't allocate memory for new list reason text!");