ngIRCd Release 17~rc3

Fix connect attempts to further IP addresses of outgoing server links If a hostname resolves to more than one IP address (round-robin DNS, IPv4 and IPv6) and an attempt to connect to the first address fails, ngIRCd should try to connect to the 2nd address, 3rd address etc. But because of a wrong variable used in the call to New_Server(), the wrong server structure has been used in further connection attemps which possibly lead to connection attempts to already connected servers.

Debian: Install default /etc/pam.d/ngircd allowing all logins This is required for backwards compatibility when installing the -full or -full-dbg package variant: PAM is enabled now but no configuration present, so all login attempts would be denied ... Creating /etc/pam.d/ngircd including "auth required pam_permit.so" restores the old behaviour of allowing all connections.

Debian: update standards to 3.9.1; add libpam0g-dev dependency

Make contrib/platformtest.sh more portable

Mac OS X package ("make osxpkg"): generate PAM configuration

Xcode builds ("make xcode"): disable pam_fail_delay() disable pam_fail_delay() only is available starting with Mac OS X 10.6; but we use the 10.5 SDK for campatibility, so don't use this function at all when building using Xcode.

Xcode: update project file, use 10.5.x SDK This is required for universal 32 bit and 64 bit builds: now code for ppc, i386, and x86_64 is generated (which requires 10.5 or newer).

Xcode builds ("make xcode"): detect version number correctly

ngIRCd release 17~rc2

Updated contrib/platformtest.sh (new version scheme) - handle version numbers generated by "git describe" - detect gcc compiler version correctly when "-std=xxx" is used

New doc/HowToRelease.txt file describing the release process

ZeroConf: include header files missing since commit a988bbc86a

Generate ngIRCd version number from GIT tag Now the ngIRCd release/version number is deduced from the "current" annotated GIT tag; see "git describe --help" for details. This is the same scheme the Linux kernel uses and gives much more details version numbers for interim releases and inofficial source archives generated using "make dist". Please note: the version number is only updated it the autogen.sh script is run; so after pulling in and pushing out new commits, you should run ./autogen.sh!

Make sourcecode compatible with ansi2knr again This allows to compile ngIRCd using a pre-ANSI K&R C compiler again: all source files are automatically converted by the included ansi2knr program (of GNU automake/autoconf) before compiling them with the K&R C compiler, but a few coding standards must be met. Tested on Apple A/UX 3.x. Regression testing on Linux and Mac OS X.

./configure: check if C compiler can compile ISO Standard C This is required for enabling ansi2knr on systems that don't have an ANSI C compiler installed (e.g. on A/UX with Apple standard C compiler).

./configure: check support for C prototypes again

Don't use PARAMS() macro for function implementations The PARAMS() macro is only needed for function prototypes; don't use it for the actual implementations.

Added m68k/apple/aux3.0.1 (gcc 2.7.2) to doc/Platforms.txt

Only try to set FD_CLOEXEC if this flag is defined A/UX 3.x doesn't implement this constant, for example.

Only use "__attribute__ ((unused))" if GCC >=2.8 is used At least GCC 2.7.2 doesn't support this attribute.

doc/Makefile.am: don¹t set docdir, automake handles it already And elder make(1) programs don¹t like "x ?= y" ...

ngIRCd release 17~rc1

New configuration option "NoZeroConf" to disable ZeroConf registration If ngIRCd is compiled to register its services using ZeroConf (e.g. using Howl, Avahi or on Mac OS X) this parameter can be used to disable service registration at runtime.

Xcode: only build current architecture in "Debug" target

doc/Platforms.txt: added NetBSD 5.0.2

Updated doc/Platforms.txt

Make sure sighandlers.h is listed in noinst_HEADERS ... because it must be included in the distribution archive :-)

const'ify ngt_SyslogFacilityName() function This fixes the following gcc compiler warning: tool.c: In function 'ngt_SyslogFacilityName': tool.c:195: warning: return discards qualifiers from pointer target type

Debian packages: build "-full" and "-full-dbg" with support for PAM

New configuration option "SyslogFacility" The new option "SyslogFacility" deines the syslog "facility" to which ngIRCd should send log messages. Possible values are system dependant, but most probably "auth", "daemon", "user" and "local1" through "local7" are possible values; see syslog(3). Default is "local5" for historical reasons.

New functions ngt_SyslogFacilityName() and ngt_SyslogFacilityID() These both functions translate syslog facility names to ID numbers and vice versa. On systems that don't define the facilitynames[] array in syslog.h, we try to build one ourself.

Explicitly cast return value of read(2) to "int" This fixes the following gcc warning, emitted by Xcode: src/ngircd/sighandlers.c: In function 'Signal_Callback': src/ngircd/sighandlers.c:239: warning: implicit conversion shortens 64-bit value into a 32-bit value

Add sighandlers.{c|h} to Xcode project And update static Mac OS X config.h used by the Xcode project.

Don't call sigaction() if it is not available on the system

Fix signalpipe file descriptor leak on RESTART Signals_Init() must only be called once. This does not affect any ngircd release version. Earlier version of this patch moved the io and sighandler initialization before the while() loop, but as Alexander Barton noticed that broke all systems without builtin select support in io.c...

sighandlers.{c|h}: Code cleanup - declare signals_catch[] array not between the function implementations. - rename now local function NGIRCd_Rehash() to Rehash(). - remove empty and therefore not used "catch SIGHUP; break;".

Make sighandlers.{c|h} compatible with ansi2knr

Updated ChangeLog to include signal handler changes

Bump version number to "17-dev"

Update ChangeLog and NEWS: include SIGUSR1/SIGUSR2 changes

Output connection status when dumping the internal server state

Reformat "server state" debug messages a little bit

Enable the daemon to dump its internal state in debug-mode. This patch allows ngIRCd to dump its internal state (connected clients, actual configuration) when compiled with --enable-debug. The daemon catches two more signals: - SIGUSR1: toggle debug mode (on/off), - SIGUSR2: dump internal state to console/syslog.

signalhandlers: add fallback to deprecated sysv API

remove NGIRCd_SignalRehash now that the main signal handling is done from the dispatcher loop we can call NGIRCD_Rehash() directly. the /REHASH handler can queue the Rehash() function for execution by sending a SIGHUP. It will be run when we return back to the dispatch loop.

Add new 'delayed' signal handlers. Allows to defer/queue signal processing for execution on the next event dispatch call, i.e. we can perform any signal action in normal, non-signal context. Example uses: - Reload everything on HUP without writing a global "SIGHUP_received" variable - Dump status of internal Lists on SIGUSR1, etc.

io: add io_cloexec to set close-on-exec flag.

ng_ipaddr.h: include assert.h We use assert() in this header, so we should include assert.h.

Conn_SyncServerStruct(): test all connections; and work case insensitive Fix synchronization of established connections and configured server structures after a configuration update: - Not only test servers that already have a connection, but also check and update configured servers to which a new connection is beeing established (SERVER_WAIT state). - And do the server name comparision case-insensitive.

Check_Servers(): skip servers already beeing connected Let CheckServers() not only skip servers that already have a connection, but also skip servers to which a new connection is already beeing established (SERVER_WAIT state).

Check_Servers(): Code cleanup

Update ChangeLog and NEWS in preparation for the next release ...

Fix linebreak in INSTALL text to fit in 80 columns

configure: correctly indent IPv6 yes/no summary output

Don't reset My_Connections[Idx].lastping when reading data This fixes PING-PONG lag calculation (which resulted in "0" before). The "lastping" time is still reset it if a time shift backwards has been detected to prevent the daemon from miscalculating ping timeouts.

write_whoreply(): respect hostname cloaking

IRC_USERHOST(): respect hostname cloaking

IRC_USERHOST(): Code cleanup & some documentation

Send_Message(): respect hostname cloaking

IRC_WriteStrClientPrefix() / Get_Prefix(): respect hostname cloaking

Refactor IRC_WriteStr{Channel|Related}Prefix(); support cloaking Move common code to new local function Send_Marked_Connections() and respect hostname cloaking.

Implement user mode "x": hostname cloaking (closes: #102) When a client has user mode "x" set, its real hostname is cloaked by substituting it with the server name (as configured in ngircd.conf). Restricted clients (user mode "r") aren't allowed to change mode "x". Please note that hostname cloaking is only in effect in server-client communication! The server still uses the real hostname for its own logging and for all server-server communication -- therefore all servers in the network must support user mode "x" to prevent older servers from leaking the real hostname of a cloaked client!

WHOWAS: respect hostname cloaking Store cloaked hostname if user mode "x" is set when the client disconnects from the server.

WHOIS: respect hostname cloaking

Implement Client_HostnameCloaked() and Client_MaskCloaked() These two functions return the cloaked hostname, if the client has enabled hostname cloaking indicated by the -- still to implement -- user mode "x". See furter patches :-)

Clean up an document Client_Hostname() and Client_Mask()

Make configure switch "--docdir" work (closes: #108)

Reformat and update FAQ.txt a little bit

INSTALL: mention SSL and IPv6

INSTALL: mention changed handling of MotdFile.

ngircd: change MOTD file handling previously, the given MotdFile file was read whenever a client requested it. Change handling to read the MotdFile contents into memory once during config file parsing. Two side effects: - changes to the MOTD file do not have any effect until ngircds configuration is reloaded - MOTD file does no longer have to reside in the chroot directory (the MOTD contents will then not be re-read on reload in that case)

startup: open /dev/null before chroot before people had to create a /dev/null inside the chroot to make redirection work.

Allow IRC ops to change channel modes even without OperServerMode set

Allow IRC operators to use MODE command on any channel (closes: #100) This allows IRC operators to change channel modes of ANY channel, even without joining these channels first.

Added mailmap file for git-[short]log and git-blame

Remove Proc_Kill(), use timeout to kill child processes This avoids a race and potentionally killing the wrong process on systems that use randomized process IDs; now the child itself is responsible to exit in a timely manner using SIGALRM.

New function Conn_CloseAllSockets() to close all open sockets This is useful in forked child processes, for example, to make sure that they don't hold connections open that the main process wants to close.

Authenticated users should be registered without the "~" mark

Don't Proc_Kill() childs after Proc_Read(): done there already.

Don't even fork a PAM-subprocess if "NoPAM" option is set

Use Proc_GenericSignalHandler() as handler for SIGTERM by default

Mark some variables as "unused" to prevent compiler warnings Some variables are only used when compiling with IDENT or PAM support or when the debug code is enabled. Mark them as "unused" so that gcc doesn't generate warnings when neither of these options is enabled.

Set NoPAM=yes in configuration files used for the testsuite

New configuration option "NoPAM" to disable PAM When the "NoPAM" configuration option is set and ngIRCd is compiled with support for PAM, ngIRCd will not call any PAM functions: all connection attemps without password will succeed instead and all connection attemps with password will fail. If ngIRCd is compiled without PAM support, this option is a dummy option and nothing changes: the global server password will still be in effect.

io.c: Include conn.h when using the select() API

Use correct preprocessor syntax when testing for PAM and IDENTAUTH

Make sure signal.h is #include'd when needed

Initial documentation for using PAM with ngIRCd

Implement asynchronous user authentication using PAM For each client connection a child process is forked which handles the actual PAM authentication and reports the result back to the master process using a pipe for communication. While the PAM authentication is in process the daemon does not block.

Add new pam.{c|h} module to Xcode project Adjust Xcode project and Mac OS X static config.h header to use PAM.

Add pam.{c|h} to project and implement PAM_Authenticate() function

New functions Client_[Set]OrigUser() to get/set user specified by peer The Client_SetOrigUser() function is used to store the peer-provided user name (see USER command) in its original form, not changed by IDENT results, for example.

Detect PAM libraries

Refactor Resolve_Read() into generic Proc_Read() function

Make Proc_Kill() more fault-tolerant

New function Conn_GetProcStat() Get PROC_STAT sub-process structure of a given connection.

Code cleanup: don't reset penalty time on DNS resolver result See commit d4632a727fbee6: it's not necessary any more!

New function Proc_GenericSignalHandler()

Rename Log_[{Init|Exit}_]Resolver to Log_[{Init|Exit}_]Subprocess Rename Log_Init_Resolver, Log_Exit_Resolver, and Log_Resolver to Log_Init_Subprocess, Log_Exit_Subprocess, and Log_Subprocess and make it more generic thereby.

Don't #include client.h when conn.h/conn-func.h is already included conn.h and cinn-func.h both already #include client.h, so it is not needed to do it twice.

New function Conn_GetFromProc() to get CONN_ID of a subprocess Get CONN_ID from file descriptor associated to a subprocess structure.

Resolver: Implement signal handler and catch TERM signal

Don't set a penalty time when doing DNS lookups The logic isn't as described in the source and intended by this code: ngIRCd doesn't wait for the asynchronous resolver process until the set penalty time is over, but until the forked process terminates or the initial connection timeout (= PongTimeout) triggers. So don't set the penalty time at all and remove the wrong comment.

Update comments: subprocesses not only can be resolver processes

Refactoring: Rename CONNECTION.res_stat to .proc_stat We want to use this process status variable not only for the resolver subprocesses but other asynchronous tasks as well; so let's name it more generic.

New "module" proc.c/proc.h for generic process handling The new "module" proc.c is used for functions dealing with child processes. At the moment, it is only used by the asynchronous resolver. All the functions already implemented habe been migrated from the resolver code base, and the rest of the ngIRCd source code has been adepted to the new namespace and calling conventions. The goal is to develop "generic" process handling functions that can be used for other purposes as well, e.g. running processes on client connects etc.

Only #include resolve.h if it is really needed

Fix redundant redeclaration of Conn_Count*() functions The wrongly placed #endif lead to the following compiler warnings: conn.h:125: warning: redundant redeclaration of ‘Conn_Count’ conn.h:125: warning: previous declaration of ‘Conn_Count’ was here conn.h:126: warning: redundant redeclaration of ‘Conn_CountMax’ conn.h:126: warning: previous declaration of ‘Conn_CountMax’ was here conn.h:127: warning: redundant redeclaration of ‘Conn_CountAccepted’ conn.h:127: warning: previous declaration of ‘Conn_CountAccepted’ was here

const'ify Conn_WriteStr() function

const'ify Send_ListChange() function in irc-mode.c

const'ify IRC_WriteStrXXX() and Get_Prefix() functions

const'ify command name variable in _COMMAND strcuture

const'ify Client_TypeText()

Add some documentation for using BOPM with ngIRCd

Implement user mode "c": receive connect/disconnect NOTICEs Users having the user mode "c" set receive NOTICE messages on each new client connection to the local server as well as disconnects. Only IRC operators (users having the mode "o" set) are allowed to set the 'c' user mode. These connect/disconnect messages can be useful for open proxy scanners -- BOPM (http://wiki.blitzed.org/BOPM) is now functional with ngIRCd, for example.

Refactor Wall_ServerNotice() into more generic Log_ServerNotice() Log_ServerNotice() sends a messages to all users having a given user mode set.

New function Conn_IPA(): get client IP address as string

ngircd.init: require $network $remote_fs when stopping ngircd

Show SSL status in WHOIS, numeric 275 "I've been wanting this for years and finally took the 5 minutes to patch it in. I took the response code (275) from whatever's running OFTC's IRC network." -- Neale Pickett <neale@woozle.org>, Fri, 11 Jun 2010 17:32:41 -0500 (OFTC is running Hybrid ircd.)

Include correct header files when testing for arpa/inet.h (Closes: #105) Tested on OpenBSD 4.7, OpenBSD 4.1, FreeBSD 8, Linux and Mac OS X. Thanks to rck <dev.rck@gmail.com> for reporting and testing!

Revert "configure: make implicit declarations fatal" This reverts commit b3a6c33da0b12ba74dc395979b677813d4bc2c0f. apparently not all gcc versions support this 8-(

configure: make implicit declarations fatal from bugzilla #105: "ngircd-16 works great under openbsd4.7/i386, but it segfaults on openbsd4.7/amd64." Caused by missing function prototypes and the resulting truncation of pointer to int. Lets try to catch these bugs during compilation instead of SIGSEGV.

Don't access already freed memory in IRC_KILL() It is not possible to call Conn_Close() after Client_Destroy() has been called, because Conn_Close wants to access the CLIENT structure which then has been freed already. Fix IRC_KILL to use Conn_Close() for local clients and Client_Destroy() for remote clients only (and never both).

fix "beeing" typo reported by Fabio Scotoni via bugzilla #101.

SSL/TLS: fix bogus 'socket closed' error message When we get there then the ssl handshake has failed, or we could not create a ssl context because ssl library initialization failed on startup. Reflect that in the log message.

ngIRCd release 16

doc/SSL: remove line continuation marker some people got confused by the '\' line continuation marker, thus put everything in a single line, even if the line gets overly long.

ngIRCd release 16~rc2

Don't reset counters on RESTART When ngIRCd restarts, all the connection counters are preserved now, as well as the command counters for example. It's unclear if resetting or not resetting is the "correct" behaviour, but it's quite clear that the behaviour should be consistent for all the counters ngIRCd uses ... And initializing "WCounter", the global but temporary write counter, is not necessarry at all: it is initialized (reset) before its use in the command parser (see parse.c).

New numeric RPL_STATSCONN (250): display connection statistics The RPL_STATSCONN numeric (250) displays information about the highest simoultaneous connection count and the number of all accepted connections since the daemon started up. Used by ircd-Hybrid, Bahamut, and Unreal for example.

Display total number of served connections on daemon shutdown

Enhace connection statistics counters This patch enables ngIRCd to count the highest maximum simultaneous connections and all the connections accepted since startup. New functions: - Conn_Count(): get current connections - Conn_CountMax(): maximum simultaneous connections - Conn_CountAccepted(): number of connections accepted

Conn_Init: code cleanup

Updated doc/Platforms.txt

Only include <netinet/in_systm.h> if it exists

Include netinet/{in.h, in_systm.h} when checking for netinet/ip.h This solves warning messages of autoconf on e.g. FreeBSD 8: configure: WARNING: netinet/ip.h: present but cannot be compiled configure: WARNING: netinet/ip.h: check for missing prerequisite headers?

Include netinet/in_systm.h alongside netinet/ip.h This fixes the following error when compiling on e.g. FreeBSD 6.x: In file included from conn.c:40: /usr/include/netinet/ip.h:160: error: syntax error before "n_long" /usr/include/netinet/ip.h:163: error: syntax error before "n_long"

Fix gcc warning "ignoring return value of ..." This patch fixes two warnings of gcc 4.4.3 when used with eglibc 2.11.1: ngircd.c: In function ‘NGIRCd_Init’: ngircd.c:801: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result conn.c: In function ‘Simple_Message’: conn.c:2041: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result The first by checking the return code and an appropriate error message, the second by "better" ignoring it (which is correct there!) ...

Only compile in Get_Error() if really needed This fixes "resolve.c:150: warning: ‘Get_Error’ defined but not used".

Updated some more copyright notices, it's 2010 already (part 2) Silly me forgot the most important place, the program output itself ...

Updated some more copyright notices, it's 2010 already :-)

ngIRCd release 16~rc1

Updated NEWS and ChangeLog file for ngIRCd 16-rc1

Don't use port 6668 as example for both "Ports" and "SSLPorts"

configure.in: only add -lnsl when needed dpkg-shlibdeps: warning: dependency on libnsl.so.1 [..] (they use none of its symbols). As shown via commit 2b14234abc252383679bae2d23861b773dc9713e (dpkg-shlibdeps: warning: dependency on libnsl.so.1) and the following revert of that commit, we cannot simply drop the AC_CHECK_LIB(nsl). Although -lnsl is indeed unneeded when glibc is used, some platforms (e.g. Solaris) need it. Use AC_SEARCH_LIBS instead to only link when the library exports a particular symbol.

Implement WEBIRC command The WEBIRC command is used by some Web-to-IRC gateways to set the correct user name and host name of users instead of their own. Syntax: WEBIRC <password> <username> <hostname> <ip-address> The <password> must be set using the new configuration variable "WebircPassword" in the [Global] section of ngircd.conf. Please note that the <ip-address> is currently not used by ngIRCd (we don't store it in the CLIENT structure, only the resolved hostname).

ngircd.conf.5: Document missing "Password" variable

Re-format Init_New_Client() function

New README-Interix.txt for running ngIRCd on MS SFU and MS SUA

Added "i586/pc/interix3.5" (MS Services for UNIX) to Platforms.txt

Quote received messages of ERROR commands in log output

Implemented new "secure clients only" channel mode: +z Only clients using a SSL encrypted connection to the server are allowed to join such a channel. But please note three things: a) already joined clients are not checked when setting this mode, b) IRC operators are always allowed to join every channel, and c) remote clients using a server not supporting this mode are not checked either and therefore always allowed to join.

Clean up and document IRC_STATS() function

Clean up and document IRC_JOIN() and join_allowed() functions

Show our name (IRCD=ngIRCd) in ISUPPORT (005) numeric Inspired by Hyperion IRC daemon.

Added missing modes to USERMODES #define Now the numeric 004 correctly reports all the supported user and channel modes (user modes "r" and "w" were missing), e. g.: :a.irc.net 004 a a.irc.net ngircd-15 aiorsw biIklmnoPstv

Updated links to ngIRCd homepage (bug tracker, mailing list)

setsockopt(): use IPPROTO_IP instead of SOL_IP to set IPTOS_LOWDELAY

Really test for netinet/ip.h and set HAVE_NETINET_IP_H

ReverseLookup(): fix documentation comment

Move NewConnection handling from callbacks to New_Connection()

Connection functions: add some more documentation comments

Clean up conn.{c|h} a little bit

Xcode: fix "-Wuninitialized is not supported without -O" Fix Apple Xcode warning "cc1: warning: -Wuninitialized is not supported without -O" when using the "Debug" build target: Detection of uninitialized automatic variable requires data flow analsys that is only enabled during optimized compilation.

Added i686/unknown/kfreebsd7.2-gnu

platformtest.sh: Only show latest commit Only show latest GIT commuit ID as version number, even when the last commit has been a merge.

Merge commit 'cade80dcf516f40e7d53124bc98526e6e5b3fb66' * commit 'cade80dcf516f40e7d53124bc98526e6e5b3fb66': Added missing contrib/platformtest.sh to distribution

Added missing contrib/platformtest.sh to distribution

Remove limit on max number of configured irc operators.

ngIRCd release 15

configtest: print ssl config options even when unset Print "SSLOptionVar =" instead of omitting the option when running --configtest with ssl enabled. This better matches the behaviour of other options, e.g. ChrootDir.

ngIRCd release 15~rc1

Updated NEWS and ChangeLog files

Make sure forwarded CONNECT commands are handled correctly

Generate WALLOPS message on operator-generated SQUIT

Enable SQUIT command for IRC Operators This patch enables IRC Operators to use the SQUIT command as specified in RFC 2812, section 3.1.8 "Squit". When forwarding SQUIT commands, the server connected to the target will drop the connection (not the target server itself!). Please note: - the configuration option "AllowRemoteOper" mus be enabled on the server disconnecting the target to allow forwarding of SQUIT commands. - if the remote server is configured to establish the connection, it will just do this; so the disconnect is not permanent in this case!

Xcode: added new op.{c|h} to project file

Use functions provided by op.c "module" Local functions Check_Oper() and No_Privileges() have been replaced by global functions in op.c "module": Op_Check() and Op_NoPrivileges().

New "module" op.c/op.h for IRC operator related functions The new "module" op.c is used to implement functions related to IRC Ops. At the moment, these two functions are available: - Op_Check() to check for a valid IRC Op, and - Op_NoPrivileges() to generate "permission denied" messages.

Allow forwarding of CONNECT commands. The syntax of the CONNECT command now is: - CONNECT <server-id> - CONNECT <server-id> <port> - CONNECT <server-id> <port> <target> - CONNECT <server-id> <port> <host> <my-pwd> <peer-pwd> - CONNECT <server-id> <port> <host> <my-pwd> <peer-pwd> <target> Note: the configuration option "AllowRemoteOper" mus be enabled on the target server to allow forwarding of CONNECT commands.

Check_Oper(): check origin of forwarded messages instead of server.

No_Privileges(): handle forwarded messages.

IRC_SendWallops(): support format string and variable parameter lists.

CONNECT, DISCONNECT: generate WALLOPS messages

New function IRC_SendWallops(). Implement new global function IRC_SendWallops() that can be called by other functions to generate WALLOPS messages to users with +w mode.

Code cleanup of IRC_DISCONNECT().

Code cleanup of IRC_SQUIT() in preparation to deal with bug #73.

New local functions Check_Oper() and No_Privileges().

Bad_OperPass(): code cleanup.

New configuration option "AllowRemoteOper" Added new configuration option "AllowRemoteOper" to control whether remote IRC operators are allowed to use administrative commands that affect this server or not This commit introduces the configuration variable, but actually no function is using it. That's up for the next patches to come ...

fix assertion failure in ng_ipaddr.c when building with debugging enabled, but without ipv6 support, ngircd dumped core when loading a config file that specified an ipv6 listen address. ngircd: ng_ipaddr.c:45: ng_ipaddr_init: Assertion `sizeof(*addr) >= res0->ai_addrlen' failed.

configtest: complain when ssl keys are not readable

Check for sockaddr_in.sin_len and initialize it Test for sockaddr_in.sin_len and initialize it to the correct value which some systems (notably Mac OS X) require. Note: this code path is only relevant when not using getaddrinfo().

Always use get{addr|name}info() when available Both getaddrinfo() and getnameinfo() are now used always when available, and not only when compiling ngIRCd with support for IPv6. This not only enables ngIRCd to handle multiple addresses per hostname when compiled without support for IPv6, but fixes binding ngIRCd to IP addresses on Mac OS X (and probably other BSD-based systems) as well: these systems require that sockaddr_in is zeroed out and sockaddr_in.sin_len is set to sizeof(sockaddr_in) like that: src/ipaddr/ng_ipaddr.c, line 54: assert(ip_str); + memset(addr, 0, sizeof *addr); + addr->sin4.sin_len = sizeof(addr->sin4); addr->sin4.sin_family = AF_INET; But this would break all the systems not using sockaddr_in.sin_len, for example Linux -- so we assume that all these systems provide getaddrinfo() and use that for now.

Xcode: add "debug" configuration to project

Fix cb_connserver() to handle aborted outgoing connections A configured server could have been removed while a connection apptempt is still in progress. So the cb_connserver() callback has to test if the server configuration record is still valid.

conn.c: fix more sizeof(..dst_addr) misuse the wrong sizeof() usage fixed in d76910ce7b9fad5679b7c614ed086e036560e37d (conn.c: fix resolver server address backlog) was a bit more widespread, fix all others, too.

resolve.c: fix valgrind 'uninitialized memory' warning fix the following warning generated by valgrind if ipv6 is enabled: Syscall param write(buf) points to uninitialised byte(s) at 0x4000982: (within /lib/ld-2.9.so) by 0x80681A8: Resolve_Name (resolve.c:477) by 0x805439F: Conn_Handler (conn.c:1658) by 0x804AA7C: main (ngircd.c:331) The warning is because ng_ipaddr_t can be a union, and only the necessary parts are initialised. The callers know what part of the union is valid, so this is not a bug.

conn.c: fix resolver server address backlog if more than one ip address is returned for a single host name, ngircd is supposed to try other addresses in case connect() to the first address returned fails for some reason. Alexander Barton noticed that this did not work at all, as the additional results were not stored.

Fix "implicit conversion shortens 64-bit value" warning This patch fixes the following gcc warning in our sources: "implicit conversion shortens 64-bit value into a 32-bit value"

Xcode: use gcc 4.0 for Mac OS X 10.4 compatibility

Channel_Mode(): fix return code of function Fix error handling of Channel_Mode() to return the correct connection status ("connected"/"disconnected") insted of always returning success.

IRC_SERVER(): code cleanup, remove unneeded variable

IRC_PASS(): remove unnecessary variable initialization

Conn_Close(): remove unused variable "txt"

Mac OS X: fix test for packagemaker(1) tool in Makefile

Fix --with-{openssl|gnutls} to accept path names This patch fixes --with-openssl and --with-gnutls and enables both to accept path names, so that you can use "./configure --with-XXX=/path". All the other --with-XXX parameters support this already.

do not add default listening port if ssl ports were specified Cosmo Kastemaa reported that its impossible to create an ssl-only setup, as ngircd binds to port 6667 by default, even if setting "Ports =". Only add the default port if _both_ "Ports" and "SSLPorts" are unspecified. Fixes bugzilla #98.

Fix LSB header of Debian init script

Use AM_SILENT_RULES([yes]), if available Starting with GNU automake 1.11 "AM_SILENT_RULES([yes])" is available to make the build process less verbose ("Linux 2.6 style") which helps to spot warning and error messages. So we use it if it is available.

Update NEWS and ChangeLog for next release

Updated doc/Platforms.txt

New script contrib/platformtest.sh This script analyzes the build process of ngIRCd and generates output suitable for inclusion in doc/Platforms.txt.

doc/Platforms.txt: ngircd builds on hppa2.0w-hp-hpux11.11 target Goetz Hoffart reports successful compile on HPUX/HPPA (on ngircd mailing list): Target: hppa2.0w-hp-hpux11.11 Compiler: gcc Compiler flags: -g -O2 -pipe -W -Wall -Wpointer-arith -Wstrict-prototypes -fstack-protector -D_XOPEN_SOURCE_EXTENDED -DSYSCONFDIR='"$(sysconfdir)"' Libraries: -lz -lnsl Syslog support: yes Enable debug code: no zlib compression: yes IRC sniffer: no Use TCP Wrappers: no Strict RFC mode: no Zeroconf support: no IRC+ protocol: yes IDENT support: no I/O backend: "poll()" IPv6 protocol: no SSL support: no

Client_CheckID(): fix connection information This patch fixes the following silly log messages: 'ID "XXX" already registered (on connection -1)!' If the ID is already registered on a local connection, the local connection ID is printed; and if the ID is connected via a remote server, "via network" is displayed.

Fix return code of Conf_EnableServer() Conf_EnableServer() only reports success if all required variables, including host name and port, are set for the specific server.

AUTHORS: update my email address

add section and rfc number to comment about QUIT error

enforce upper limit on maximum number of handled commands reported on #ngircd: pasting lots of lines into a channel can kill off many people on the channel if the read buffer is drained quickly enough and the client-side TCP can't keep up with the incoming data. This implements a throttling scheme: - an irc client may send up to 3 commands per second before a one second pause is enforced. - an irc client may send up to 256 bytes per second before a one second pause is enforced. After discussion with Alexander Barton, server <-> server links are treated specially: There is no artificial limit on the number of bytes sent per second, and up to 10 commands are processed per second before a pause is enforced. It may be neccessary to make those limits tuneable to accomondate larger networks, but for now they are compile time values.

conn.c: fix NumConnections imbalance New_Server() can call Conn_Close() in its error paths, but that function decrements the number of current active connections. Thus we need to increment it earlier.

SSL/TLS: fix error handling when ssl ctx init for outgoing server link fails

SSL/TLS: fix error path in gnutls ssl ctx allocation

manpage: move SSLConnect option to the right section

SSL/TLS: remove redundant asserts/ifdefs

SSL/TLS: proper indentation, remove erroneous comment

Update copyright notice, it's 2009 already!

Updated Debian "changelog" file for ngIRCd 14.1

ngIRCd release 14.1

Added start/stop script for Red Hat based distributions Script contributed by Naoya Nakazawa <naoya@sanow.net>.

Renamed contrib/ngircd.sh to contrib/ngircd-bsd.sh

security: fix remotely triggerable crash in SSL/TLS code When a server is running with SSL/TLS support compiled in, it is trivial to crash the server by sending an MOTD request via another server in the network. - ONLY servers without ssl/tls support compiled in are not affected. Disabling SSL in the configuration (no ssl listening ports, etc) does NOT help. - servers that are running standalone (i.e., not connected to any other servers) are not affected, either. This affects all ngircd releases since ngircd 13 (earlier versions have no SSL/TLS support).

Fixed "Conflicts:" line in debian/control: missing comma

Debian: build ngircd-full-dbg package In addition to the "ngircd" and "ngircd-full" packages a new package named "ngircd-full-dbg" is build: this package contains all the features of the "full" package but includes debug code and both the --debug and --sniffer options and the resulting binaries are _not_ stripped.

debian/rules: whitespace fixes

Fix server list announcement When ngircd announces the list of currently known servers to a new (connecting) server, it sent the introducer of the servers instead of the top server. Assuming this network: irc1.example.com |--irc2.example.com | `--irc3.example.com | `--irc4.example.com `--irc5.example.com When irc4 connects to irc3, irc3 tells irc4 that irc5 was connected to irc2. (irc2 had introduced irc5 to irc3; but thats not what ngircd should have sent to the new server). This also placed users on the wrong servers.

Doxygen: update source code repository link to GIT

allow ping timeout quit messages to show the timeout value

irc-server: do not remove hostnames from info text that code does not really make sense -- the info text is freely cofngiureable and des not follow a specific format. Also, that "+2" might have caused invalid memory accesses.

conn-zip: fix error handling callers of (Un)Zip_Buffer() assume that the function closes the connection on error. However, this was not always the case.

remove or translate old comments

client.c: remove unecessary comments

add const qualifier to pointers where possible

ngIRCd release 14

Display IPv6 addresses as "[<addr>]" when accepting connections. With this patch ngIRCd displays IPv6 addresses as "[<addr>]:<port>" when accepting new connections and later, if no successful DNS lookup could be made (or DNS is disabled altogether).

Xcode: #define include __DATE__ in VERSION Change VERSION to include the __DATE__ when compiling from within Xcode. When building using "make xcode" or "make osxpkg" VERSION already is defined to the "real" version number set in configure.in.

Fix ChangeLog: Local channels are already implemented in Release 13

Fix up last Debian changelog entry

ngIRCd release 14~rc1

Updated NEWS and ChangeLog files

Updated Debian/Linux init script - PidFile, ServerUID and ServerGID are read from actual server configuration - Exit code and behaviour is more LSB compliant - New "status" and "test" sub-functions

misspelling in ERR_NORECIPIENT reply

Add missing contributors to AUTHORS file

testsuite: add more predefined channels to server config make sure it creates & and +, and accepts channel names without a special character (ngircd should treat 'Name = chan' as 'Name = #chan').

allow creation of persistent modeless channels

add and use Channel_IsModeless() avoid "name[0] == '+'" where possible, having Channel_IsModeless() makes things much more obvious.

Enhance INFO command to report compile time, if available

Update NEWS and ChangeLog files

Channel mode changes: break on error Don't echo multiple syntax error messages (461) on invalid commands, but break after the first one. In addition, this solves corrupted 'Unknown mode "+' messages.

Channel_Mode(): code cleanup (no functional changes)

TLS/SSL: remove useless error message when ssl connection is closed When using OpenSSL, the following annoying "error" message was logged whenever an encrypted connection was shut down in a orderly fashion: TLS/SSL Connection shutdown: ConnSSL_Read: Unable to determine error of course, this isn't an error at all.

update ChangeLog.

SSL/TLS: clear all ssl realted flags on shutdown one ssl related flags was not cleared on ssl shutdown. introduce and use CONN_SSL_FLAGS_ALL to zap them all.

TLS/SSL: fix memory leak when using compressed server links with ssl commit 6bc2d3d06e9cb4da68ea4b63d9b6b219d88ab927 (New connection option CONN_RFC1459) forgot to adjust the ssl bitmasks. The result is that when a compressed AND encrypted server link goes down the memory allocated by zlib and the r/w buffers are no longer free'd as the previous ConnSSL_Free() would then also remove the CONN_ZIP flag from the flag mask.

Fix spelling of log message: "channek" vs. "channel" ...

Channel key file: store file name and open on each access. Store the file name of channel key files and reopen them on each access (on each JOIN command) insted of just storing the file handles. This eliminates the special requirements (no delete) and makes sure that always the actual file contents are used in all circumstances.

Support individual channel keys for pre-defined channels. This patch introduces the new configuration variable "KeyFile" for [Channel] sections in ngircd.conf. Here a file can be configured for each pre-defined channel which contains individual channel keys for different users. This file is line-based and must have the following syntax: <user>:<nick>:<key> <user> and <nick> can contain the wildcard character "*". Please not that these channel keys are only in effect, when the channel has a regular key set using channel mode "k"!

RFC 2812, sec. 3.3.1: really check for the last dot This fixes commit 5a3128243f4b60 and makes the test suite ("make check") run again without errors.

irc.c: reject masks with wildcard after last dot RFC 2812 says in section 3.3.1 ("Private Messages"): The mask MUST have at least 1 (one) "." in it and no wildcards following the last ".".

irc.c: Fix handling of channels containing dots commit 2546a13ad2949192eb70bf21e114ec60af287ee4 ('Cumulative Message Patch') broke PRIVMSG to channels containing dots. Fix this by switching evaluation order: Check first if the target matches a existing channel and only do a check for target masks if that failed. PRIVMSG with host/server masks is described in RFC 2812, section 3.3.1. Makes one wonder how a server is _really_ supposed to tell the difference between hostmasks and channel names. Sigh.

Update ngircd.spec file - Change Copyright to License - Update URL - Make BuildRoot use %{_tmppath} macro - Add basic BuildRequires - Compile with zlib and openssl - Install all docs in standard document location Signed-off-by: Ask Bjørn Hansen <ask@develooper.com>

remove unneeded LOG_DEBUG when not compiling with DEBUG support when ngircd is build without DEBUG enabled, LOG_DEBUG messages are always discarded. To avoid the extra code, ngircd has a LogDebug() wrapper which gets removed by the compiler when compiling without DEBUG defined. Update a few functings which were using the Log(LOG_DEBUG, .. interface directly without #ifdef DEBUG guards. text data bss dec hex filename 127748 1900 28280 157928 268e8 ngircd.before 126836 1896 28280 157012 26554 ngircd.after

documentation: gnutls does not support password-protected privkeys already mentioned in man page and sample config file, but for completeness also document it in doc/SSL.txt.

Mac OS X: update texts for Mac OS X Installer.app

Xcode: build ngIRCd with IPv6 support on Mac OS X

Xcode: get release number dynamically; new make target "xcode-clean". - make target "xcode" now detects the release number stored in the configure.in file and passes it to Xcode. - new make target "xcode-clean" which removes all files generated by "make xcode" and removes the Xcode build directory.

Xcode: define TARGET_VENDOR and TARGET_OS

Add new and missing files to Mac OS X Xcode project

Rename Channel_Free() to Free_Channel(), it is a local function

Clean up channel allocation table on shutdown/restart. Silly bug: the condition of a while() loop in the Channel_Exit() function used the wrong variable and therefore got never executed ... This bug is in the code since the beginning (see commit bb19cfda in 2002); shame on me!

Add Channel_Free(). Central function to free a channel structure and all its resources (invite/ban lists, topic, ...).

Clean up (reformat and comment) Delete_Channel() function.

Free topic array on channel deletion. The topic array in the CHANNEL structure must be free()'d before the channel itself becomes deleted.

Fix spelling in some documents.

Allow pre-defined server local channels ("&").

Spell check and enhance ngIRCd manual pages.

man ngircd.conf: line break missing before the SSLConnect description reported by Christoph Biedl.

defines.h: remove MAX_LISTEN_PORTS, MAX_SERVICES _SERVICES was never used; _LISTEN_PORTS is a leftover from commit 51ccb5928ad1453b0593fedd934298384d09e619 ('internal changes needed for future ssl support').

Remove limit on max number of predefined channels. This resolves Bugzilla Bug 68 ('Too many pre-defined channels configured.')

channel.c: constify a few function arguments.

use %ld as format specifier for posix data types in the same vein as the earlier commit: cast posix data types (pid_t, ...) to long and use %ld as format specifier. This will avoid problems when sizeof(int) != sizeof(type). We could also cast to int, but this might truncate the value.

ngIRCd release 13

don't print pid_t type with %ld format specifier Reported by Christoph Biedl: ngircd[21581]: Running as user irc(39), group irc(39), with PID 140733193409613. cast pid_t to long to avoid this. While we are there, cast uid_t and gid_t, too.

Update the date ("Dec 2008") of the manual pages.

doc/Platforms.txt: added x86_64/unknown/linux-gnu

doc/Platforms.txt: update list of tested platforms.

doc/SSL.txt: enhance documentation.

doc/Services.txt: explain which IRC Services versions are compatible

Testsuite start-server.sh: return correct exit code. src/testsuite/start-server.sh returns 0 when no errors occurred and the daemon has been startet and 1 on errors. Always returning 0 is wrong ...

Make testsuite (getpid.sh) work on OpenSolaris (i386/pc/solaris2.11).

doc/Services.txt: document using ngIRCd with IRC Services.

sample-ngircd.conf: remove now unused CVS "$Id$"

ngIRCd release 13~rc1

Fix double minus signs in manual pages This patch fixes the following lintian(1) warning: "Manual page seems to contain a hyphen where a minus sign was intended. '-' chars are interpreted as hyphens (U+2010) by groff, not as minus signs (U+002D). Since options to programs use minus signs (U+002D), this means for example in UTF-8 locales that you cannot cut&paste options, nor search for them easily. '-' must be escaped ('\-') to be interpreted as minus."

Debian package ("make deb"): fix some lintian(1) warnings

Change formatting of some log messages - Fix formatting of some log messages, mostly punctuation. - cb_Connect_to_Server(): don't use string concatenation, because it is not supported by pre-ANSI C compilers ...

Fix pem_passwd_cb(): unused variable "rwflag" (OpenSSL) This patch fixes the following warning of GCC (version 4.3.2) in function pem_passwd_cb() when compiling with OpenSSL support and without debug code: conn-ssl.c: In function 'pem_passwd_cb': conn-ssl.c:122: warning: unused parameter 'rwflag'

New configuration option "NoIdent" to disable IDENT lookups The new configuration option "NoIdent" in ngircd.conf can be used to disable IDENT lookups even when the ngIRCd daemon is compiled with IDENT lookups enabled.

Implement the IRC command "SERVLIST" The IRC command "SERVLIST" lists all the registered services, see RFC 2811, section 3.5.1. The syntax is "SERVLIST [<mask> [<type>]]". The parameter <type> is not used by ngIRCd at the moment, all registered services are of type 0 (which is the default when omitted).

Updated NEWS and ChangeLog, using NEWS for news only :-)

Create local &SERVER channel and log server messages to it ngIRCd now creates a server-local channel &SERVER with channel modes +mnPt (moderated, no messages from outside the channel, persistent and with the topic locked) and logs all the messages to it that a user with mode +s ("server messages") receives. If an IRC operator withdraws the +P ("persistent") mode and the &SERVER channel is freed because of no members, nothing special happens. The channel can be recerated any time later and ngIRCd would begin logging to it again.

Implement local channels (prefix "&") This patch implements server-local channels, prefix "&", that are only visible to users of the same local server and not in the network. Patch written by Scott Perry (2008-06-04), see: - http://arthur.barton.de/cgi-bin/bugzilla/show_bug.cgi?id=87 - http://arthur.barton.de/cgi-bin/bugzilla/attachment.cgi?id=24&action=view

Added some missing files of GIT tree to distribution archives The following bits and bytes were not included in distribution archives: - contrib: ngindent, ngircd.sh - contrib/Debian: ngircd.postinst - contrib/MacOSX: preinstall.sh, postinstall.sh - doc/src: Doxyfile, header.inc.html, footer.inc.html, ngircd-doc.css - src/portab: splint.h

Test suite: start two servers and test server-server links I changed the test suite to start two test servers (on port 6789 and 6790), so server-server links can be tested as well for which I included the new test script "server-link-test.e". In addition the documentation of the test suite (src/testsuite/README) has been updated and is more complete now.

Add conf-ssl.h to "noinst_HEADERS" conf-ssl.h must be listed in "noinst_HEADERS" so that it becomes included in distribution archives generated by "make dist" and "make distcheck".

Re-add CVE identifiers to ChangeLog. I'm lame. My last commit removed all the CVE numbers recently added in commit 598df0758 to the ChangeLog ... shame on me! See all the CVE entries of ngIRCd at: <http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=ngircd>

Updated NEWS and ChangeLog to include 0.12.1 and the development version

Connection counter: count outgoing connections as well. This patch lets ngIRCd count outgoing connections as well as incoming connections (up to now only outgoing connections have been counted). This change is required because the Conn_Close() function doesn't know whether it closes an outgoing connection or not and therefore would decrement the counter below zero when an outgoing connection existed -- which would trigger an assert() call ... Please note that this patch changes the (so far undocumented but now fixed) behaviour of the "MaxConnections" configuration option to account the sum of the in- and outbound connections!

Ignore numeric 020 ("please wait while we process your coinnection") Some servers send the numeric 020 ("please wait while we process your connection") when a client connects. This is no useful information for this server, so we simply ignore it :-)

GNUTLS: define new API types when installed library is too old This patch enables ngIRCd to use GNUTLS in really old versions, tested with version 1.0.16, that don't define the "new" data types ending in xxx_t. LIBGNUTLS_VERSION_MAJOR isn't defined there as well, so we use it to test if we must define the new types on our own.

Console log: output timestamp (seconds since start) for resolver, too

Console log: output timestamp (seconds since start of daemon)

conn-ssl.c: work around gnutls API problems on 64 bit platforms Alexander Barton reported a compiler warning on 64-bit platforms: cc1: warnings being treated as errors conn-ssl.c: In function 'ConnSSL_Init_SSL': conn-ssl.c:403: error: cast to pointer from integer of different size Unfortunately, I couldn't find a real solution; the GNUTLS API expects 'gnutls_transport_ptr_t' (which is void*), but the default push/pull functions (send/recv) expect an int. The only alternative solution is to pass in an address to the file descriptor, then add send/recv wrappers that expect a pointer. What a mess[tm].

GIT: don't ignore cvs-version.{h|new}, because it isn't used any more.

Fix ForwardLookup(): "ISO C90 forbids specifying subobject to initialize" This patch fixes the following warning of GCC (version 4.3.2) in function ForwardLookup(): resolve.c: In function 'ForwardLookup': resolve.c:282: warning: ISO C90 forbids specifying subobject to initialize resolve.c:284: warning: ISO C90 forbids specifying subobject to initialize resolve.c:285: warning: ISO C90 forbids specifying subobject to initialize

Fix ConnSSL_LogCertInfo(): unused variable "cred" (GNUTLS) This patch fixes the following warning of GCC (version 4.3.2) in function ConnSSL_LogCertInfo() when compiling with GNUTLS support: conn-ssl.c: In function 'ConnSSL_LogCertInfo': conn-ssl.c:542: warning: unused variable 'cred'

Debian: build ngircd-full with support for GNU TLS and IPv6.

Debian: make sure that /var/run/ircd is owned by user "irc".

GIT: Ignore Debian-related generated files. Added files that become generated while building Debian GNU/Linux packages of ngIRCd to the .gitignore lists.

Updated config.{guess|sub} to version 2008-01-16.

Enable KICK to be handled from remote servers and from services.

Respect RFC 1459 compatibility mode when announcing channels (no NJOIN).

Document the server flag "S": SERVICE command is supported.

Announce IRC services in the network. This patch - introduces a new server flag "S" to indicate that the server can handle the SERVICE command (on server links), - implements the IRC command "SERVICE" for server-server links, - uses the "SERVICE" command to announce IRC services when a new server connects to it, - and fixes the Send_Message() function to let it send messages to services using a "target mask". If the remote server doesn't indicate that it can handle the "SERVICE" command (it has not set the "S" flag), services are announced as regular users as before.

Change Introduce_Client() to set the correct client type (user/service).

Convert SQUERY to PRIVMSG on RFC 1459 compliant links.

Don't allow SQUERY to send to "target masks" and channels; only services!

Fix PRIVMSG/NOTICE handler (II): keep command when forwarding to channels. - new function ngt_UpperStr(). - change Channel_Write() to take command name and error flag. - remove now unneeded function Channel_Notice().

New function ngt_UpperStr()

Fix PRIVMSG/NOTICE handler Send_Message(): don't forward NOTICE as PRIVMSG.

Make real use of the CLIENT_SERVICE client type. This patch enables ngIRCd to handle IRC services as real services, and not as "fake users": - Set correct client type CLIENT_SERVICE for services, - Change log messages to include correct client type, - PRIVMSG: allow users to send messages to services, - Send services nick names to other servers (as users). Please note that this patch doesn't announce services as services in the network, but as regular users (as before). Only the local server knows of services as services (see LUSERS command, for example). It is up to one of the next patches to fix this and to introduce the SERVICE command in server to server communication. The propagation of services as regular users between servers doesn't limit the functionality of the IRC services and will be the fallback for servers that don't support "real" services propagation in the future.

Allow IRC services to change their nick names.

New function Client_TypeText() and Destroy_UserOrService(). Client_TypeText() is used to get correct naming ("Client", "Service", ...) for log messages, and Destroy_UserOrService() is used to correctly destroy user and services clients.

Send_Message(): really enforce target client type.

sample-ngircd.conf & ngircd.conf(5): document "ServiceMask" option.

Allow ngIRCd to detect services connected to an "virtual services server". Introduce a new configuration variable "ServiceMask" in SERVER blocks to define a mask matching nick names that should be treated as services. Regular servers don't need this parameter (leave it empty, the default), but you should set it to "*Serv" when connection ircservices, for example. This patch allows ngIRCd to detect services, it doesn't change the functionality: you only get different log messages ;-)

Centralize logging functions in Introduce_Client().

Get rid of INTRO_INFO structure again: we don't need it at all! All the required information is already stored in the CLIENT structure of new new connection, so pass this to Introduce_Client() and don't invent an unneeded new structure ...

Announce_User(): support RFC 1459 compatibility mode.

Introduce_Client(): send MODES in RFC 1459 mode, too.

numeric.c: whitespace fixes ...

Server links: detect RFC 1459 mode direct after SERVER command This patch allows ngIRCd to detect right after receiving the SERVER command from the peer whether the RFC 1459 compatibility mode must be used or not. And it fixes the announcement of users during establishing new server links with such peers.

Send and handle NICK+USER commands for user registration (RFC 1459). This patch enables ngIRCd to deal with NICK and USER commands following RFC 1459 to register new clients, and to send these commands instead of one full NICK command as specified in RFC 2813 on connections that are in RFC 1459 compatibility mode. Can be useful for e. g. IRC services that simulate a RFC 1459 server.

New function IRC_WriteStrServersPrefixFlag_CB() using a callback function.

New function Introduce_Client() to announce new local and remote users.

New connection option CONN_RFC1459. This new connection option CONN_RFC1459 indicates that the peer on this link only supports the IRC protocol as defined in RFC 1459 and that the compatibility mode (e. g. for outgoing commands like NICK) should be used.

New global function Conn_SetOption().

USER: servers and services can alter user information after registration. This is required to do RFC 1459 style user registration on server links, and is used by some services packages, too. See RFC 1459 section 4.1.3.

NICK: allow servers and services to use RFC 1459 syntax (2 parameters). This patch allows servers and services to call the NICK command using the syntax defined in RFC 1459 to register new users, with only two parameters. See section 4.1.2. Useful for some services packages, which emulate this protocol.

Whitespace fixes: remove trailing tabulator characters.

conn-ssl.c: don't append a newline to ConnSSL_GetCipherInfo

TLS/SSL support: code changes. This adds the required code to enable ssl/tls support during compile and run time, respectively.

TLS/SSL support: documentation.

TLS/SSL support: core files. Contains support for both OpenSSL and GNU TLS. Certificate Authentification is not yet supported.

Fix handling of MaxConnections option Config option claimed to be 'number of connections' but in reality this was treated as 'largest file descriptor allowed'. This also fixes another bug in New_connection, where the ng_ipaddr_tostr_r error path was missing a return statement.

Include "mcheck.h" when using mtrace().

SECURITY: Fixed a message handling bug which could crash the daemon. Some message targets could lead to a NULL pointer dereference and therefore could crash the daemon (denial of service). (cherry picked from commit e493ad2d30ff80bca2556cde2212e367cb006517)

Enable GNU libc "memory tracing" when compiled with debug code. This patch lets ngIRCd activate "memory tracing" of the GNU libc when compiled with debug code (configure: --enable-debug) and the functionality is available on the system. (http://www.gnu.org/software/libc/manual/html_node/Allocation-Debugging.html)

New make target: "osxpkg" to create an Mac OS X installer package. This patch adds a new make target, "osxpkg", to the main Makefile which gereates a Apple Mac OS X installer package of ngIRCd. The packagemaker(1) project bundle is stored in contrib/MacOSX/ngIRCd.pmdoc.

Clean up Mac OS X Xcode environment. - Remove obsolete contrib/MacOSX/cvs-version.h - Change SDK to 10.4

doc/Platforms.txt: added Debian GNU/Hurd, "i686/unknown/gnu0.3"

Added CVE identifiers to ChangeLog. see http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=ngircd

Remove de.barton.ngircd.plist on "make clean", its a generated file.

Make ngIRCd compile and run on NeXTSTEP 3.3 and OPENSTEP 4.2 by Steven D. Blackford <kb7sqi@aol.com>: "I wanted to let you know that I've done a quick port of ngircd-0.12.0 for NEXTSTEP3.3/OPENSTEP4.2. There wasn't a lot of changes required to get it to compile clean, but I did make the necessary changes so that I didn't have to use -posix flag. The NeXT has a pretty buggy POSIX implementation so I always try to work around it. :-) Anway, here's the changes required to get it to compile."

Merge branch 'master' of git://ngircd.barton.de/ngircd

Install /Library/LaunchDaemons/de.barton.ngircd.plist into $(DESTDIR)

FAQ: add entry about /OPER and OperCanUseMode

GIT: added src/testsuite/message-test to ignore list.

Fix Validate_Args(): unused parameter "Idx" and "Req" This patch fixes the following error message of GCC (tested with version 4.3.0) when not compiling ngIRCd in "strict RFC" mode: parse.c: In function "Validate_Args": parse.c:341: error: unused parameter "Idx" parse.c:341: error: unused parameter "Req"

message-test: Disable two tests using "localhost" as host name Some operating systems, for example OpenBSD and OpenSolaris, use "localhost.<domain>" instead of just "localhost" for 127.0.0.1, so the "message-test" using "localhost" failed on such systems. Don't have an idee how to make this work on all platforms ... :-/ So I simply disabled the two affected tests to make the testsuite run on OpenBSD and OpenSolaris again.

Fix Send_Message(): "lastCurrentTarget" may be used uninitialized This patch fixes the following warning of GCC 4.3.1: irc.c: In function "Send_Message": irc.c:315: error: "lastCurrentTarget" may be used uninitialized in this function

Fix t_diff(): declaration of 'div' shadows a global declaration This patch fixes the following GCC warning message: irc-info.c:422: warning: declaration of 'div' shadows a global declaration

Cosmetic whitespace and line length fixes, mostly in Send_Message().

Added "message-test" to Makefile, so it is distrubuted and run.

Cleaned up PRIVMSG and NOTICE patches.

Cumulative Message Patch

Don't allow empty channel names ("#") in strict RFC mode. This closes Bug #88. Patch proposed by Eric <egrunow@ucsd.edu>, but with wrong length comparision: please note that Channel_IsValidName() checks the name INCLUDING the prefix, so the test must be length<=1!

Return 461 (syntax error) on "JOIN :" and "PART :" Up to this patch ngIRCd did not return any result (GIT master) or a badly formated 403 (":irc.server 403 test :No such channel" [note the two spaces!], branch-0-12-x) on the above commands, this patch changes the behaviour to reflect ircd 2.11 which returns 461 in both cases.

Channel_Join(): Code cleanup.

Added more supported and tested platforms to doc/Platforms.txt.

Fixes to misc-test: accept "localhost.<domain>" as well as "localhost" Some operating systems, for example OpenBSD, use "localhost.<domain>" instead of "localhost", so the "who-test" expecting "localhost" failed on such systems. (Please see 149859c5fecc..., which fixes this for the who-test already)

Revert "dpkg-shlibdeps: warning: dependency on libnsl.so.1 [..]" - Solaris needs both -lsocket _and_ -lnsl - A/UX needs -lUTIL "... which totally sucks because we'd link libnsl on Linux, too (where its not needed at all). So, we have to figure out how to tell autocrap to NOT put -lnsl there unless it exports a symbol we need. This also means that [...] has to be reverted (or done properly)." -- Florian Westphal @ #ngircd This reverts commit 2b14234abc252383679bae2d23861b773dc9713e.

dpkg-shlibdeps: warning: dependency on libnsl.so.1 [..] (they use none of its symbols). So, rip out that AC_CHECK_LIB cruft, pointed out by Christoph Biedl. If there are platforms that really need that we should only link when we actually use these libraries.

Merge autogen.sh changes Merge commit 'alex/master'

autogen.sh: Don't set AUTO{CONF|MAKE}_VERSION and WANT_AUTO{CONF|MAKE} On some systems (for example Gentoo Linux, FreeBSD, and OpenBSD), these variables are used to select which version of GNU automake and autoconf to use, but we shouldn't depend on a specific version -- instead we should use the "system default". So probably it is up to the user to set these variables accordingly to set up some wrapper scripts of his operating system distribution.

Translated comments from German to English

autogen.sh: correctly test for and export ACLOCAL variable

Fix GCC warnings for possibly uninitialized variables in IRC_JOIN This patch fixes the following two warnings of GCC 4.2.4: irc-channel.c: In function "IRC_JOIN": irc-channel.c:185: warning: "lastkey" may be used uninitialized in this function irc-channel.c:185: warning: "lastchan" may be used uninitialized in this function

GIT: added src/src/config.h.in~ to ignore list.

Allow mixed line terminations (CR+LF/CR/LF) in non-RFC-compliant mode Up to now ngIRCd accepted CR+LF as well as a single CR or LF in "non RFC compliant" mode (the default). But ngIRCd became confused when it received data containing mixed line endings (e. g. "111\r222\n333\r\n"). This patch enables ngIRCd (in "non RFC compliant" mode) to detect CR+LF, CR, and LF as equally good line termination sequences and to always end the command after the first one detected. Some clients (for exmaple Trilian) are that ... broken to send such mixed line terminations ... First patch proposed by Scott Perry <scperry@ucsd.edu>, Thanks to Ali Shemiran <ashemira@ucsd.edu> for testing!

Don't allow stray \r or \n in command parameters If ngircd receives an input line like "COMMAND arg\nIRRELEVANT\r\n", "arg\nIRRELEVANT" is passed as an argument to COMMAND. This can lead to output like: :ngircd.test.server 322 nick #chan 1 : topicwithprecedingnewline :ngircd.test.server 322 nick #nxtchan 1 : [..] Worse, this allows clients to piggyback irc commands, e.g. "TOPIC #a :test\n:fake!~a@nonexistant JOIN :#a\r\n", which causes the client to receive a JOIN command during /LIST output. Bug reported by Scott Perry, first patch by Florian Westphal.

GIT: ignore de.barton.ngircd.plist, it is a generated file.

ngircd.init: use LSB logging functions, if available.

--configtest: return non-zero exit code if there are errors

Handle_Buffer(): code cleanup. Both callers ignore the return code of this function, so get rid of it, but make sure that the client is disconnected on errors.

Conn_Handler(): cleanup code, add/translate comments. In addition, the "timeout" variable has been removed because it is unnecessary today: Handle_Buffer() handles all the data it can handle, and io_dispatch() returns immediately when new data is available. So we don't have to double-check but better sleep. Pointed out by Florian.

Use strtok_r instead of strchr in IRC_JOIN. This patch does significant cleanup on the join code by using strtok_r instead of mangling strchr to parse channel names and keys in parallel when a JOIN command contains a list of channels and keys. Also adds an strtok_r implementation to libportab.

Mac OS X LaunchDaemon script: log messages to /Library/Logs/ngIRCd.log

configure.in: don't check for "obvious" standard functions. Drop checks for the following C standard functions: malloc, memmove, memset, realloc, strchr, strcspn, strerror, strstr. Rationale: These are standard K&R/C89 functions, no point in ''making sure they exist''.

Reset client idle time on NICK, JOIN, and PART

Remove ListenIPv4/ListenIPv6 options. Use "Listen = list,of,addresses" instead.

make Listen parameter a comma-seperated list of addresses. this also obsoletes ListenIPv4 and ListenIPv6 options. If Listen is unset, it is treated as Listen="::,0.0.0.0". Note: ListenIPv4 and ListenIPv6 options are still recognized, but ngircd will print a warning if they are used in the config file. Also, some plattforms require that ai_socktype is set in the getaddrinfo() hints structure.

Add option aliases -V (for --version) and -h (for --help). This patch adds -h and -V short options (to complement the usage). It is based on a patch attached to Debian bug #466063, see <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=466063>. Idea by Jari Aalto <jari.aalto@cante.net>, patch adapted by Alexander Barton <alex@barton.de>.

Add FAQ entry for 'Where is the log file'?

Add tests for MOTD, VERSION, TIME, USERHOST The misc-test.e file is also somewhat reorganized and commented here. Patch from Brandon Beresini, Bryan Caldwell and Dana Dahlstrom.

Updated list of authors (AUTHORS file)

Update master development branch - use "dev" instead of "HEAD" as "version number", - update ChangeLog and NEWS to reflect the 0.12.0 release.

Merge commit 'aad49bd260494878aed6795c7a897ad1d28c3082'

This patch implements a (maybe) compliant WHOWAS command. It is hard to test this in the test suite because we 1) shouldn't rely on previous tests populating WHOWAS and 2) don't connect a user for more than 30 seconds. Also makes WHOWAS return ERR_NONICKNAMEGIVEN_MSG as implied by RFC.

Update ngIRCd manual pages - Update timestamp, - enhance some phrasing, - and fix "Passive" ([Server]) formatting.

If bind() fails, also print ip address and not just the port number.

GIT: ignore symbolic links to tests in testsuite directory Added symbolic links to new tests (invite-test, join-test, and kick-test) to .gitignore file.

Fixes to who-test: accept "localhost.<domain>" as well as "localhost" Some operating systems, for example OpenBSD, use "localhost.<domain>" instead of "localhost", so the "who-test" expecting "localhost" failed on such systems.

ng_ipaddr.h must include netinet/in.h. compile on FreeBSD 5.4 failed with: ./../ipaddr/ng_ipaddr.h:34: error: field `sin4' has incomplete type Reported and tested by Jefferson S Almeida.

Removed space after # so that Cygwin's version of expect recognizes comments.

Fix secret channel information leak /who on a secret channel that the user is not a member of now returns proper RPL_ENDOFWHO_MSG instead of nothing.

Added Cygwin uid kludge. (verified working)

Anglified and improved comments in channel.c and channel.h [Dana Dahlstrom: repair tab/space conversion in patch]

Implement IRC commands SERVICE, SERVLIST, and SQUERY as dummy functions SERVICE, SERVLIST, and SQUERY are required by RFC 2812 (it states in section 3 that "all commands described in this section MUST be implemented by any server for this protocol." -- So we implement them without (much) actual functionality ...

Add invite-test.e to test suite.

Tests for the INVITE command.

Invite: prefix last argument with colon when necessary.

tests for JOIN and various replies Brandon Beresini sent me a patch yesterday adding tests for JOIN under various circumstances, which I believe he worked on with Bryan Caldwell and Ali Shemiran. I made a few modifications; the result is below.

Allow KICK to handle comma-delimited lists (of channels, nicks). includes test cases. [fw@strlen.de: - move code around to avoid duplication - use const where possible - integrate test case]

Invite: Send RPL_AWAY to client sending the invite if target is away.

Fixes to who-test: accept any ident, escape some '*' flags. This prevents who-test.e from failing when ngircd is performing ident lookups and an ident server is running.

IRC_INVITE: coding style cleanup.

Constify some of Channel_Kick()s arguments.

constify Client_Search() argument.

Allow IRC ops to ignore channel limits when joining Allow IRC ops to ignore any channel limit (bans, invite only etc.) when they want to join a channel.

Handle 1-character messages terminated with CR or LF correctly Code cleanup and fix for Bug #83, "ngIRCd chokes on 1-character messages" in function Handle_Buffer(): the buffer is now correctly cleared when ngIRCd receives 1-character messages terminated with either CR or LF (in violation to RFC 2812, section 2.3 "Messages", 5th paragraph).