commit c16133c5ee72256ef5b8fa586e72e5e3598e75bb from: Alexander Barton date: Wed Jan 25 16:11:44 2012 UTC New_Connection(): don't set the client hostname twice Setting the hostname twice doesn't do much harm a lot, but isn't elegant. And for IPv6 addresses, it isn't correct the first time (missing []) ... commit - 48889844299e036515e567aa5f992df18ccdf2d7 commit + c16133c5ee72256ef5b8fa586e72e5e3598e75bb blob - 078449c0b1c882cd2eeab92ca11409c686a7d46e blob + 7e28e8fb1035006d540e9f3e4b7ba7d720944662 --- src/ngircd/client.c +++ src/ngircd/client.c @@ -186,7 +186,6 @@ Init_New_Client(CONN_ID Idx, CLIENT *Introducer, CLIEN assert(Idx >= NONE); assert(Introducer != NULL); - assert(Hostname != NULL); client = New_Client_Struct(); if (!client) blob - 71dc939f0e3ce0ce5a46107ed555cfa7334e398d blob + 82dbb288d9e281e0a4c72ec4ff9f3bfce1e218b1 --- src/ngircd/conn.c +++ src/ngircd/conn.c @@ -1438,7 +1438,7 @@ New_Connection(int Sock) return -1; } - c = Client_NewLocal(new_sock, ip_str, CLIENT_UNKNOWN, false); + c = Client_NewLocal(new_sock, NULL, CLIENT_UNKNOWN, false); if (!c) { Log(LOG_ALERT, "Can't accept connection: can't create client structure!");