commit b8482fd3cfdb429aec75575958f4d5d4e9ae22df
from: Alexander Barton <alex@barton.de>
date: Sat Aug 01 12:26:11 2015 UTC

First check if channel has mode "N", then check membership

This should be more efficient.

commit - 90ea23ab4fe3032824e22eb59bee305f35c4aae7
commit + b8482fd3cfdb429aec75575958f4d5d4e9ae22df
blob - 35026e5587300d08ebb61f9bf9af3a9f99824475
blob + 9fca622ba0ea66422940e2d71dc2dff0d5f2eee4
--- src/ngircd/irc-login.c
+++ src/ngircd/irc-login.c
@@ -266,8 +266,8 @@ IRC_NICK( CLIENT *Client, REQUEST *Req )
 			   !Client_HasMode(Client, 'o')) {
 				chan = Channel_First();
 				while (chan) {
-					if(Channel_IsMemberOf(chan, Client) &&
-					   Channel_HasMode(chan, 'N'))
+					if(Channel_HasMode(chan, 'N') &&
+					   Channel_IsMemberOf(chan, Client))
 						return IRC_WriteErrClient(Client,
 									  ERR_NONICKCHANGE_MSG,
 									  Client_ID(Client),