commit 52d8fa2c09c36632c1cacd8242e22e9de920ec9f
from: Alexander Barton <alex@barton.de>
date: Sun May 03 22:58:24 2020 UTC

Update Client_SetHostname() to not use strpbrk()

Not sure about the portability of strpbrk() in really ancient OS, and
this was the only place where it became used recently in ngIRCd ...
So let's play it safe! ;-)

commit - 1f40776bc166ece8dad0d333905481aa28786cb5
commit + 52d8fa2c09c36632c1cacd8242e22e9de920ec9f
blob - 1c7bd1ead0cc510a814d59f0c43d12c1e1bb65da
blob + 67c0260423ac8a3e2ca9a099397691eeae40711a
--- src/ngircd/client.c
+++ src/ngircd/client.c
@@ -339,9 +339,9 @@ Client_SetHostname( CLIENT *Client, const char *Hostna
 
 	/* Only cloak the hostmask if it has not yet been cloaked.
 	 * The period or colon indicates it's still an IP address.
-	 * An empty string means a rDNS lookup did not happen (yet).
-         */
-	if (Conf_CloakHost[0] && (!Client->host[0] || strpbrk(Client->host, ".:"))) {
+	 * An empty string means a rDNS lookup did not happen (yet). */
+	if (Conf_CloakHost[0] && (!Client->host[0] || strchr(Client->host, '.')
+				  || strchr(Client->host, ':'))) {
 		char cloak[GETID_LEN];
 
 		strlcpy(cloak, Hostname, GETID_LEN);