commit 430bb223765281487e5c6d415a8efb91e2bf3320
from: Alexander Barton <alex@barton.de>
date: Mon May 25 21:30:07 2020 UTC

Enhance debug logging for PONG commands

Distinguish between expected and unexpected PONG commands.

commit - dc6807338e240d8093f43337dab7bfe488c35c4a
commit + 430bb223765281487e5c6d415a8efb91e2bf3320
blob - f682e216f273279501d33a036973cdb738ba9848
blob + 368a03d46bef6ff775ecc029051b427d21cbef32
--- src/ngircd/irc-login.c
+++ src/ngircd/irc-login.c
@@ -877,9 +877,17 @@ IRC_PONG(CLIENT *Client, REQUEST *Req)
 		    (long)(time(NULL) - Conn_GetSignon(conn)),
 		    time(NULL) - Conn_GetSignon(conn) == 1 ? "" : "s",
 		    Client_UserCount(), Channel_CountVisible(NULL));
-	} else
-		LogDebug("Connection %d: received PONG. Lag: %ld seconds.",
-			 conn, (long)(time(NULL) - Conn_LastPing(conn)));
+	}
+#ifdef DEBUG
+	else {
+		if (Conn_LastPing(conn) > 1)
+			LogDebug("Connection %d: received PONG. Lag: %ld seconds.",
+				 conn, (long)(time(NULL) - Conn_LastPing(conn)));
+		else
+			LogDebug("Got unexpected PONG on connection %d. Ignored.",
+				 conn);
+	}
+#endif
 
 	/* We got a PONG, so signal that none is pending on this connection. */
 	Conn_UpdatePing(conn, 1);