commit 147e424d98091a3627091edbfdab9fca52f21938
from: JRMU <jrmu@lecturify.com>
via: Alexander Barton <alex@barton.de>
date: Mon Sep 09 13:30:44 2019 UTC

Fix hostmask cloaking bug, don't cloak multiple times

Previously, each server would cloak every user's hostmask. The problem
is that if a network has more than one server, then a user's hostmask
would get cloaked twice. This patch ensures that a server only cloaks
the hostmask if it has not yet been cloaked (the period indicates it's
still an IP address).

Closes #228.

commit - e954b59d414fb32b89291514d0d690c9ebabba49
commit + 147e424d98091a3627091edbfdab9fca52f21938
blob - 7e6ff68afd4b8cf84e68d116f2ebe3bcd64d0fc3
blob + a453312c3e93473a8a0ee7c2c8cf1c4a5b652660
--- src/ngircd/client.c
+++ src/ngircd/client.c
@@ -337,7 +337,9 @@ Client_SetHostname( CLIENT *Client, const char *Hostna
 	assert(Client != NULL);
 	assert(Hostname != NULL);
 
-	if (Conf_CloakHost[0]) {
+	/* Only cloak the hostmask if it has not yet been cloaked (the period
+	 * indicates it's still an IP address). */
+	if (Conf_CloakHost[0] && strchr(Client->host, '.')) {
 		char cloak[GETID_LEN];
 
 		strlcpy(cloak, Hostname, GETID_LEN);