Commit Diff

Commit:
90e6ec3f897608eb3ac9accc9d0ef8fc16be7314
From:
Alexander Barton <alex@barton.de>
Date:
Message:
The server didn't validate weather the target user of a channel user mode change is a valid channel member or not (from HEAD).
Actions:
Patch | Tree
commit - 9810da343c586fb89490847540d410ff03c7bdec
commit + 90e6ec3f897608eb3ac9accc9d0ef8fc16be7314
blob - ccd46b29fd631b99bcbf9680a36414cb08fb08cc
blob + a518461a5b06352c8422a66abfbeb20b6893c98f
--- src/ngircd/irc-mode.c
+++ src/ngircd/irc-mode.c
@@ -14,7 +14,7 @@
 
 #include "portab.h"
 
-static char UNUSED id[] = "$Id: irc-mode.c,v 1.24.2.4 2003/01/17 19:08:57 alex Exp $";
+static char UNUSED id[] = "$Id: irc-mode.c,v 1.24.2.5 2003/01/21 21:05:19 alex Exp $";
 
 #include "imp.h"
 #include <assert.h>
@@ -507,6 +507,13 @@ Channel_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Or
 		/* Is there a valid mode change? */
 		if( ! x[0] ) continue;
 
+		/* Validate target client */
+		if( client && ( ! Channel_IsMemberOf( Channel, client )))
+		{
+			if( ! IRC_WriteStrClient( Origin, ERR_USERNOTINCHANNEL_MSG, Client_ID( Origin ), Client_ID( client ), Channel_Name( Channel ))) break;
+			continue;
+		}
+
 		if( set )
 		{
 			/* Set mode */