commit 4d595292ee725266b7313feac1be0f588955b3d6
from: Markus Uhlin <markus@nifty-networks.net>
date: Sun Aug 17 15:00:30 2025 UTC

FindHistory2: cleaned up autofix

commit - 4e27656730c12ac39cec7b18b60b9d2f7dc2461b
commit + 4d595292ee725266b7313feac1be0f588955b3d6
blob - 4d0fe29067ab3e3f7f5dc3c51b158a37788c6ab5
blob + 1554ffd8ecc3d1fd2aa87ff0441ce6c424034e81
--- FICS/obsproc.c
+++ FICS/obsproc.c
@@ -1019,6 +1019,7 @@ FindHistory2(int p, int p1, int p_game, char *End, con
 {
 	FILE		*fpHist;
 	char		 fmt[80] = { '\0' };
+	char		*resolvedPath;
 	int		 index = 0;
 	long int	 when = 0;
 	static char	 fileName[MAX_FILENAME_SIZE];
@@ -1053,29 +1054,29 @@ FindHistory2(int p, int p1, int p_game, char *End, con
 
 	fclose(fpHist);
 
-	/* Validate 'when' before using it in a path */
-	if (when <= 0 || when > LONG_MAX) {
-		pprintf(p, "Invalid history timestamp for %s.\n", parray[p1].name);
+	if (when < 0) {
+		pprintf(p, "Invalid history timestamp for %s.\n",
+		    parray[p1].name);
 		return NULL;
 	}
 
 	msnprintf(fileName, sizeof fileName, "%s/%ld/%ld", hist_dir,
 	    (when % 100), when);
 
-	/* Validate that the resolved path is within hist_dir */
-	char *resolvedPath = realpath(fileName, NULL);
-	if (resolvedPath == NULL) {
-		warnx("%s: %s: realpath failed", __func__, fileName);
+	// Validate that the resolved path is within hist_dir
+	if ((resolvedPath = realpath(fileName, NULL)) == NULL) {
+		warn("%s: realpath", __func__);
 		return NULL;
 	}
+
 	if (strncmp(resolvedPath, hist_dir, strlen(hist_dir)) != 0) {
-		warnx("%s: %s: path traversal detected", __func__, resolvedPath);
+		warnx("%s: path traversal detected", __func__);
 		free(resolvedPath);
 		return NULL;
 	}
-	/* Copy resolvedPath back to fileName for return */
-	strncpy(fileName, resolvedPath, sizeof(fileName) - 1);
-	fileName[sizeof(fileName) - 1] = '\0';
+
+	// Copy 'resolvedPath' back to 'fileName' for return
+	mstrlcpy(fileName, resolvedPath, sizeof fileName);
 	free(resolvedPath);
 
 	return (&fileName[0]);