commit 3bf0c6f3b9cbeded68c2c7f7a6f2a020616b73f5
from: Alexander Barton <alex@barton.de>
date: Wed Sep 30 14:00:05 2009 UTC

Bad_OperPass(): code cleanup.

commit - f78b0c61e967c66386803a3dc77069c66bd664de
commit + 3bf0c6f3b9cbeded68c2c7f7a6f2a020616b73f5
blob - b0271df2576a99dff7f3d493034a0765e53b57e3
blob + 736163c107e6b6b135ddde4370b8eb720811f77d
--- src/ngircd/irc-oper.c
+++ src/ngircd/irc-oper.c
@@ -35,14 +35,19 @@
 #include "irc-oper.h"
 
 
+/**
+ * Handle invalid received OPER command.
+ * Log OPER attempt and send error message to client.
+ */
 static bool
 Bad_OperPass(CLIENT *Client, char *errtoken, char *errmsg)
 {
-	Log( LOG_WARNING, "Got invalid OPER from \"%s\": \"%s\" -- %s", Client_Mask( Client ),
-										errtoken, errmsg);
+	Log(LOG_WARNING, "Got invalid OPER from \"%s\": \"%s\" -- %s",
+	    Client_Mask(Client), errtoken, errmsg);
 	IRC_SetPenalty(Client, 3);
-	return IRC_WriteStrClient( Client, ERR_PASSWDMISMATCH_MSG, Client_ID( Client ));
-}
+	return IRC_WriteStrClient(Client, ERR_PASSWDMISMATCH_MSG,
+				  Client_ID(Client));
+} /* Bad_OperPass */
 
 
 GLOBAL bool
@@ -63,7 +68,7 @@ IRC_OPER( CLIENT *Client, REQUEST *Req )
 		return Bad_OperPass(Client, Req->argv[0], "not configured");
 
 	if( strcmp( Conf_Oper[i].pwd, Req->argv[1] ) != 0 )
-		return Bad_OperPass(Client, Conf_Oper[i].name, "Bad password");
+		return Bad_OperPass(Client, Conf_Oper[i].name, "bad password");
 
 	if( Conf_Oper[i].mask && (! Match( Conf_Oper[i].mask, Client_Mask( Client ) )))
 		return Bad_OperPass(Client, Conf_Oper[i].mask, "hostmask check failed" );