commit 05748aa5eeaf75438a0bb238967667605fe4d52e from: Florian Westphal date: Fri Apr 29 21:27:56 2011 UTC parse: fix logical expression testing for non RFC1459 links parse.c:284: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' The expression looks dubious, this should probably be an if-not-set, then... test. commit - 0bb892bb5fe1f0d9d783808d211c039e11e12f3b commit + 05748aa5eeaf75438a0bb238967667605fe4d52e blob - d7dbffc28f951465bfc6f300173e390aa9c0b131 blob + c2603918ff430643d045d8e5d95bdfcca43eec8f --- src/ngircd/parse.c +++ src/ngircd/parse.c @@ -280,7 +280,7 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Clos assert( client != NULL ); if (!Req->prefix && Client_Type(client) == CLIENT_SERVER - && !Conn_Options(Idx) & CONN_RFC1459 + && !(Conn_Options(Idx) & CONN_RFC1459) && strcasecmp(Req->command, "ERROR") != 0 && strcasecmp(Req->command, "PING") != 0) {