Commit Diff

Commit:
7faa3ed7d6613f23e998604461f543e763278f7e
From:
Alexander Barton <alex@barton.de>
Date:
Message:
Pidfile_Create(): Don't leak file descriptor on error path Detected by cppcheck: [src/ngircd/ngircd.c:502]: (error) Resource leak: pidfd
Actions:
Patch | Tree
commit - c9b152fa4119bc0f4ca27a2e163840a1e2dfbbc5
commit + 7faa3ed7d6613f23e998604461f543e763278f7e
blob - f28ff05bcfb778065dc99a50e7459472eee8a68f
blob + 8a93bcb00839a796b262b890d12b373d662ccf56
--- src/ngircd/ngircd.c
+++ src/ngircd/ngircd.c
@@ -498,7 +498,8 @@ Pidfile_Create(pid_t pid)
 
 	len = snprintf(pidbuf, sizeof pidbuf, "%ld\n", (long)pid);
 	if (len < 0 || len >= (int)sizeof pidbuf) {
-		Log( LOG_ERR, "Error converting pid");
+		Log(LOG_ERR, "Error converting pid");
+		close(pidfd);
 		return;
 	}