Commit Diff

Commit:
dbe87ff772a3aea31757f336f2bfe9ff4bc53973
From:
Markus Uhlin <markus@nifty-networks.net>
Date:
Message:
GetPlayersFormula: fixed possible out-of-bounds array access (found by PVS-Studio)
Actions:
Patch | Tree
commit - d0d2e11aaab21c45f979de0ad37b424ecb01d9bd
commit + dbe87ff772a3aea31757f336f2bfe9ff4bc53973
blob - dd5ff234b68cf6d262d38ff0bd43b4512a01e81e
blob + 740012f51cb850f4ce67e22f5ff0d752cd31c3e2
--- FICS/formula.c
+++ FICS/formula.c
@@ -68,7 +68,7 @@
 PRIVATE char *
 GetPlayersFormula(player *pWho, int clause)
 {
-	if (clause == MAX_FORMULA)
+	if (clause < 0 || clause >= (int)ARRAY_SIZE(pWho->formulaLines))
 		return pWho->formula;
 	return pWho->formulaLines[clause];
 }